From 703579f722fcedc7f6253eb9f973e4185949756a Mon Sep 17 00:00:00 2001
From: Ivan Babrou <github@ivan.computer>
Date: Wed, 19 May 2021 10:02:23 -0700
Subject: [PATCH] python3Packages.cryptography: add missing libiconv build
dependency on darwin
Fixing the following:
```
error: linking with `/nix/store/l3ca456ppdy8hi9hc0rvyr6mrm76si08-clang-wrapper-11.1.0/bin/cc` failed: exit code: 1
= note: ld: library not found for -liconv
```
---
pkgs/development/python-modules/cryptography/default.nix | 3 ++-
pkgs/top-level/python-packages.nix | 4 +++-
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/pkgs/development/python-modules/cryptography/default.nix b/pkgs/development/python-modules/cryptography/default.nix
index fd6cbfc512e..9b35b5654e2 100644
--- a/pkgs/development/python-modules/cryptography/default.nix
+++ b/pkgs/development/python-modules/cryptography/default.nix
@@ -15,6 +15,7 @@
, pytest
, pytest-subtests
, pretend
+, libiconv
, iso8601
, pytz
, hypothesis
@@ -48,7 +49,7 @@ buildPythonPackage rec {
] ++ (with rustPlatform; [ rust.cargo rust.rustc ]);
buildInputs = [ openssl ]
- ++ lib.optional stdenv.isDarwin darwin.apple_sdk.frameworks.Security;
+ ++ lib.optionals stdenv.isDarwin [ darwin.apple_sdk.frameworks.Security libiconv ];
propagatedBuildInputs = [
packaging
six
diff --git a/pkgs/top-level/python-packages.nix b/pkgs/top-level/python-packages.nix
index 1608984f288..23da1eab54d 100644
--- a/pkgs/top-level/python-packages.nix
+++ b/pkgs/top-level/python-packages.nix
@@ -1590,7 +1590,9 @@ in {
cryptacular = callPackage ../development/python-modules/cryptacular { };
- cryptography = callPackage ../development/python-modules/cryptography { };
+ cryptography = callPackage ../development/python-modules/cryptography {
+ inherit (pkgs.darwin) libiconv;
+ };
cryptography_vectors = callPackage ../development/python-modules/cryptography/vectors.nix { };