public/nixpkgs
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

tor-browser-bundle-bin: optionally disable multiprocess support

Browse Source 
Multiprocess tabs always crash, as first reported by the issue mentioned
below.  It is now consistently reproducible both on NixOS and non-NixOS
for me, so I've decided to add a toggle to conveniently disable
multiprocess support as a work-around.

Closes https://github.com/NixOS/nixpkgs/issues/27759 but does
not really fix the underlying problem ...
This commit is contained in:
Joachim Fasting 2017-09-15 11:41:49 +02:00
parent 1df6cf5d1d
commit 69e3817eb6
No known key found for this signature in database
GPG Key ID: 66EAB6B14F6B6E0D
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
pkgs/applications/networking/browsers/tor-browser-bundle-bin/default.nix
View File

@ -44,6 +44,10 @@
, hicolor_icon_theme , hicolor_icon_theme
, shared_mime_info , shared_mime_info
# Whether to disable multiprocess support to work around crashing tabs
# TODO: fix the underlying problem instead of this terrible work-around
, disableContentSandbox ? true
# Extra preferences # Extra preferences
, extraPrefs ? "" , extraPrefs ? ""
}: }:
@ -210,6 +214,10 @@ stdenv.mkDerivation rec {
lockPref("extensions.torlauncher.control_port_use_ipc", true); lockPref("extensions.torlauncher.control_port_use_ipc", true);
lockPref("extensions.torlauncher.socks_port_use_ipc", true); lockPref("extensions.torlauncher.socks_port_use_ipc", true);
// Optionally disable multiprocess support. We always set this to ensure that
// toggling the pref takes effect.
lockPref("browser.tabs.remote.autostart.2", ${if disableContentSandbox then "false" else "true"});
${optionalString (extraPrefs != "") '' ${optionalString (extraPrefs != "") ''
${extraPrefs} ${extraPrefs}
''} ''}