public/nixpkgs
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

bundlerApp: take buildInputs (#45435)

Browse Source 
It would be reasonable to have a Ruby program that depends on some other
program being in the PATH. In this case, the obvious thing to do would
be something like this:

    bundlerApp {
      # ...
      buildInputs = [ makeWrapper ];
      postBuild = ''
        wrapProgram "$out/bin/foo" \
          --prefix PATH : ${lib.makeBinPath [ dep ]}
      '';
    }

However, this doesn't work, because even though it just forwards most of
its arguments to `runCommand`, `bundlerApp` won't take a `buildInputs`
parameter. It doesn't even specify its own `buildInputs`, which means
that the `scripts` parameter to `bundlerApp` (which depends on
`makeWrapper`) is completely broken, and, as far as I can tell, has been
since its inception. I've added a `makeWrapper` build input if the
scripts parameter is present to fix this.

I've added a `buildInputs` option to `bundlerApp`. It's also passed
through to bundled-common because `postBuild` scripts are run there as
well. This actually means that in this example we'd end up going through
two layers of wrappers (one from `bundlerApp` and one from
bundled-common), but that has always been the case and isn't likely to
break anything. That oddity does suggest that it might be prudent to
not forward `postBuild` to bundled-common (or to at least use a
different option) though...

FWIW, as far as I can tell no package in nixpkgs uses either the
`scripts` or `postBuild` options to `bundlerApp`.
This commit is contained in:
Alyssa Ross 2018-10-29 21:39:51 +00:00 committed by zimbatm
parent 3947b88389
commit 69dcb1a2c0
2 changed files with 16 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
pkgs/development/ruby-modules/bundled-common/default.nix
View File

@ -19,6 +19,7 @@
, meta ? {} , meta ? {}
, groups ? ["default"] , groups ? ["default"]
, ignoreCollisions ? false , ignoreCollisions ? false
, buildInputs ? []
, ... , ...
}@args: }@args:
@ -96,7 +97,7 @@ let
envPaths = lib.attrValues gems ++ lib.optional (!hasBundler) bundler; envPaths = lib.attrValues gems ++ lib.optional (!hasBundler) bundler;
basicEnv = buildEnv { basicEnv = buildEnv {
inherit ignoreCollisions; inherit buildInputs ignoreCollisions;
name = name'; name = name';

10
pkgs/development/ruby-modules/bundler-app/default.nix
View File

@ -1,4 +1,4 @@
{ lib, stdenv, callPackage, runCommand, ruby }@defs: { lib, stdenv, callPackage, runCommand, makeWrapper, ruby }@defs:
# Use for simple installation of Ruby tools shipped in a Gem. # Use for simple installation of Ruby tools shipped in a Gem.
# Start with a Gemfile that includes `gem <toolgem>` # Start with a Gemfile that includes `gem <toolgem>`
@ -26,6 +26,7 @@
, allowSubstitutes ? false , allowSubstitutes ? false
, installManpages ? true , installManpages ? true
, meta ? {} , meta ? {}
, buildInputs ? []
, postBuild ? "" , postBuild ? ""
, gemConfig ? null , gemConfig ? null
}@args: }@args:
@ -33,8 +34,11 @@
let let
basicEnv = (callPackage ../bundled-common {}) args; basicEnv = (callPackage ../bundled-common {}) args;
cmdArgs = removeAttrs args [ "pname" "postBuild" "gemConfig" ] cmdArgs = removeAttrs args [ "pname" "postBuild" "gemConfig" ] // {
// { inherit preferLocalBuild allowSubstitutes; }; # pass the defaults inherit preferLocalBuild allowSubstitutes; # pass the defaults
buildInputs = buildInputs ++ lib.optional (scripts != []) makeWrapper;
};
in in
runCommand basicEnv.name cmdArgs '' runCommand basicEnv.name cmdArgs ''
mkdir -p $out/bin mkdir -p $out/bin