From 5058d365a1876614ca2a48d8ced389ab032664d2 Mon Sep 17 00:00:00 2001 From: Mario Rodas Date: Sun, 2 Dec 2018 20:26:22 -0500 Subject: [PATCH 1/3] pyre: 0.0.17 -> 0.0.18 --- pkgs/development/tools/pyre/default.nix | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/pkgs/development/tools/pyre/default.nix b/pkgs/development/tools/pyre/default.nix index 02772f9f791..c71e9e821da 100644 --- a/pkgs/development/tools/pyre/default.nix +++ b/pkgs/development/tools/pyre/default.nix @@ -3,12 +3,12 @@ let # Manually set version - the setup script requires # hg and git + keeping the .git directory around. - pyre-version = "0.0.17"; # also change typeshed revision below with $pyre-src/.typeshed-version + pyre-version = "0.0.18"; # also change typeshed revision below with $pyre-src/.typeshed-version pyre-src = fetchFromGitHub { owner = "facebook"; repo = "pyre-check"; rev = "v${pyre-version}"; - sha256 = "0y86a3g5xbgh0byksyx5jw7yq7w840x85dhz9inz6mkg5j06mcis"; + sha256 = "1sy1lk9j3hq20dabfkr9s4r7prrcndrs345a5iqz6yzvakr4r74d"; }; versionFile = writeScript "version.ml" '' cat > "./version.ml" < Date: Mon, 3 Dec 2018 08:19:07 +0000 Subject: [PATCH 2/3] pyre: remove unused makeWrapper --- pkgs/development/tools/pyre/default.nix | 2 -- 1 file changed, 2 deletions(-) diff --git a/pkgs/development/tools/pyre/default.nix b/pkgs/development/tools/pyre/default.nix index c71e9e821da..fb6c8dd84be 100644 --- a/pkgs/development/tools/pyre/default.nix +++ b/pkgs/development/tools/pyre/default.nix @@ -29,8 +29,6 @@ let src = pyre-src; - nativeBuildInputs = [ makeWrapper ]; - buildInputs = with ocamlPackages; [ ocaml findlib From 3d444cfd8e0a02f5854104c06cbcc0f6905ae6a8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=B6rg=20Thalheim?= Date: Mon, 3 Dec 2018 08:19:28 +0000 Subject: [PATCH 3/3] pyre: simplify build phases --- pkgs/development/tools/pyre/default.nix | 19 ++++++++----------- 1 file changed, 8 insertions(+), 11 deletions(-) diff --git a/pkgs/development/tools/pyre/default.nix b/pkgs/development/tools/pyre/default.nix index fb6c8dd84be..87066284bfe 100644 --- a/pkgs/development/tools/pyre/default.nix +++ b/pkgs/development/tools/pyre/default.nix @@ -44,32 +44,29 @@ let # python36Packages.python36Full # TODO ]; - buildPhase = '' + preBuild = '' # build requires HOME to be set - export HOME=. + export HOME=$TMPDIR # "external" because https://github.com/facebook/pyre-check/pull/8/files sed "s/%VERSION%/external/" dune.in > dune - cp ${versionFile} ./scripts/generate-version-number.sh + ln -sf ${versionFile} ./scripts/generate-version-number.sh mkdir $(pwd)/build export OCAMLFIND_DESTDIR=$(pwd)/build export OCAMLPATH=$OCAMLPATH:$(pwd)/build - - make release ''; - checkPhase = '' - make test - # ./scripts/run-python-tests.sh # TODO: once typeshed and python bits are added - ''; + buildFlags = [ "release" ]; + + doCheck = true; + # ./scripts/run-python-tests.sh # TODO: once typeshed and python bits are added # Note that we're not installing the typeshed yet. # Improvement for a future version. installPhase = '' - mkdir -p $out/bin - cp ./_build/default/main.exe $out/bin/pyre.bin + install -D ./_build/default/main.exe $out/bin/pyre.bin ''; meta = with stdenv.lib; {