From fd10431871ad57e54d593f17928b2db576471d99 Mon Sep 17 00:00:00 2001 From: talyz Date: Wed, 14 Apr 2021 16:14:28 +0200 Subject: [PATCH 1/4] tengine: Add modules to passthru Follow the interface of the `nginx` package and expose the enabled modules. This is used in the `nginx` module to enable the `additionalModules` option. --- pkgs/servers/http/tengine/default.nix | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/pkgs/servers/http/tengine/default.nix b/pkgs/servers/http/tengine/default.nix index 01e5c0950dc..db01edec315 100644 --- a/pkgs/servers/http/tengine/default.nix +++ b/pkgs/servers/http/tengine/default.nix @@ -111,6 +111,10 @@ stdenv.mkDerivation rec { mv $out/sbin $out/bin ''; + passthru = { + inherit modules; + }; + meta = { description = "A web server based on Nginx and has many advanced features, originated by Taobao"; homepage = "https://tengine.taobao.org"; From 06dee38345cbad53ddfa7616a962be49777b1a72 Mon Sep 17 00:00:00 2001 From: talyz Date: Wed, 14 Apr 2021 16:34:10 +0200 Subject: [PATCH 2/4] Revert "nixos/nginx: fix eval for tengine" This reverts commit 2d3200e010cc4c6fae62d9f6c31357cb97d606d4. --- nixos/modules/services/web-servers/nginx/default.nix | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/nixos/modules/services/web-servers/nginx/default.nix b/nixos/modules/services/web-servers/nginx/default.nix index ea745eabf78..7591ad0c3d2 100644 --- a/nixos/modules/services/web-servers/nginx/default.nix +++ b/nixos/modules/services/web-servers/nginx/default.nix @@ -818,7 +818,7 @@ in ProtectControlGroups = true; RestrictAddressFamilies = [ "AF_UNIX" "AF_INET" "AF_INET6" ]; LockPersonality = true; - MemoryDenyWriteExecute = !(builtins.any (mod: (mod.allowMemoryWriteExecute or false)) (optionals (cfg.package ? modules) cfg.package.modules)); + MemoryDenyWriteExecute = !(builtins.any (mod: (mod.allowMemoryWriteExecute or false)) cfg.package.modules); RestrictRealtime = true; RestrictSUIDSGID = true; PrivateMounts = true; From 1ef95a8c5fd293a4c3eab1b264e41e0c714abcb2 Mon Sep 17 00:00:00 2001 From: talyz Date: Wed, 14 Apr 2021 16:39:35 +0200 Subject: [PATCH 3/4] nginx: Add all the nginx tests to passthru.tests --- pkgs/servers/http/nginx/generic.nix | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/pkgs/servers/http/nginx/generic.nix b/pkgs/servers/http/nginx/generic.nix index d249d47a215..663193789a5 100644 --- a/pkgs/servers/http/nginx/generic.nix +++ b/pkgs/servers/http/nginx/generic.nix @@ -142,7 +142,10 @@ stdenv.mkDerivation { passthru = { modules = modules; - tests.nginx = nixosTests.nginx; + tests = { + inherit (nixosTests) nginx nginx-auth nginx-etag nginx-pubhtml nginx-sandbox nginx-sso; + variants = lib.recurseIntoAttrs nixosTests.nginx-variants; + }; }; meta = if meta != null then meta else { From 4aab79918e8bd911a2ba859113b0e6e3b9f3e923 Mon Sep 17 00:00:00 2001 From: talyz Date: Wed, 14 Apr 2021 16:56:54 +0200 Subject: [PATCH 4/4] tengine: Add passthru.tests --- pkgs/servers/http/tengine/default.nix | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/pkgs/servers/http/tengine/default.nix b/pkgs/servers/http/tengine/default.nix index db01edec315..d7c8ea226fe 100644 --- a/pkgs/servers/http/tengine/default.nix +++ b/pkgs/servers/http/tengine/default.nix @@ -1,5 +1,5 @@ { lib, stdenv, fetchFromGitHub, openssl, zlib, pcre, libxml2, libxslt -, substituteAll, gd, geoip, gperftools, jemalloc +, substituteAll, gd, geoip, gperftools, jemalloc, nixosTests , withDebug ? false , withMail ? false , withStream ? false @@ -113,6 +113,7 @@ stdenv.mkDerivation rec { passthru = { inherit modules; + tests = nixosTests.nginx-variants.tengine; }; meta = {