thinkfan: cleanup

- Remove the custom installPhase: upstream has added an install target
and it does a better job than we do

- Improve meta: description -> longDescription and add a short one

- Fix license: GPL3 -> GPL3+

pkgs/tools/system/thinkfan/default.nix

@@ -1,5 +1,13 @@
-{ lib, stdenv, fetchFromGitHub, cmake, libyamlcpp, pkg-config
+{ lib
-, smartSupport ? false, libatasmart }:
+, stdenv
+, fetchFromGitHub
+, cmake
+, libyamlcpp
+, pkg-config
+, procps
+, coreutils
+, smartSupport ? false, libatasmart
+}:
 
 stdenv.mkDerivation rec {
   pname = "thinkfan";
@@ -21,27 +29,16 @@ stdenv.mkDerivation rec {
 
   buildInputs = [ libyamlcpp ] ++ lib.optional smartSupport libatasmart;
 
-  installPhase = ''
+  meta = {
-    runHook preInstall
+    description = "A simple, lightweight fan control program";
-
+    longDescription = ''
-    install -Dm755 {.,$out/bin}/thinkfan
+      Thinkfan is a minimalist fan control program. Originally designed
-
+      specifically for IBM/Lenovo Thinkpads, it now supports any kind of
-    cd "$NIX_BUILD_TOP"; cd "$sourceRoot" # attempt to be a bit robust
+      system via the sysfs hwmon interface (/sys/class/hwmon).
-    install -Dm644 {.,$out/share/doc/thinkfan}/README.md
+    '';
-    cp -R examples $out/share/doc/thinkfan
+    license = lib.licenses.gpl3Plus;
-    install -Dm644 {src,$out/share/man/man1}/thinkfan.1
-
-    runHook postInstall
-  '';
-
-  meta = with lib; {
-    description  = "A minimalist fan control program";
-    longDescription = "A minimalist fan control program. Originally designed
-specifically for IBM/Lenovo Thinkpads, it now supports any kind of system via
-the sysfs hwmon interface (/sys/class/hwmon).";
-    license = licenses.gpl3;
     homepage = "https://github.com/vmatare/thinkfan";
-    maintainers = with maintainers; [ domenkozar ];
+    maintainers = with lib.maintainers; [ domenkozar ];
-    platforms = platforms.linux;
+    platforms = lib.platforms.linux;
   };
 }