From 52f21069d0495b4ea216909f9624d12cffe55fdf Mon Sep 17 00:00:00 2001 From: Eelco Dolstra Date: Fri, 12 Aug 2016 16:35:35 +0200 Subject: [PATCH] Remove the Cassandra module MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit It uses import-from-derivation, which is a bad thing, because this causes hydra-evaluator to build Cassandra at evaluation time. $ nix-instantiate nixos/release.nix -A tests.cassandra.i686-linux --dry-run error: cannot read ‘/nix/store/c41blyjz6pfvk9fnvrn6miihq5w3j0l4-cassandra-2.0.16/conf/cassandra-env.sh’, since path ‘/nix/store/0j9ax4z8xhaz5lhrwl3bwj10waxs3hgy-cassandra-2.0.16.drv’ is not valid, at /home/eelco/Dev/nixpkgs/nixos/modules/services/databases/cassandra.nix:373:11 Also, the module is a mess (bad option descriptions, poor indentation, a gazillion options where a generic "config" option would suffice, it opens ports in the firewall, it sets vm.swappiness, ...). --- nixos/modules/module-list.nix | 1 - nixos/release.nix | 1 - 2 files changed, 2 deletions(-) diff --git a/nixos/modules/module-list.nix b/nixos/modules/module-list.nix index 36ec2651965..f5747428825 100644 --- a/nixos/modules/module-list.nix +++ b/nixos/modules/module-list.nix @@ -136,7 +136,6 @@ ./services/continuous-integration/jenkins/slave.nix ./services/databases/4store-endpoint.nix ./services/databases/4store.nix - ./services/databases/cassandra.nix ./services/databases/couchdb.nix ./services/databases/firebird.nix ./services/databases/hbase.nix diff --git a/nixos/release.nix b/nixos/release.nix index b67cd198d2e..4647a02afb1 100644 --- a/nixos/release.nix +++ b/nixos/release.nix @@ -211,7 +211,6 @@ in rec { tests.boot = callSubTests tests/boot.nix {}; tests.boot-stage1 = callTest tests/boot-stage1.nix {}; tests.cadvisor = hydraJob (import tests/cadvisor.nix { system = "x86_64-linux"; }); - tests.cassandra = callTest tests/cassandra.nix {}; tests.chromium = (callSubTests tests/chromium.nix { system = "x86_64-linux"; }).stable; tests.cjdns = callTest tests/cjdns.nix {}; tests.containers-ipv4 = callTest tests/containers-ipv4.nix {};