cockroachdb: install bash completion into .bin

pkgs/servers/sql/cockroachdb/default.nix

@@ -2,37 +2,36 @@
 
 buildGoPackage rec {
   name = "cockroach-${version}";
-  version = "v1.1.1";
+  version = "1.1.1";
 
   goPackagePath = "github.com/cockroachdb/cockroach";
 
   src = fetchurl {
-    url = "https://binaries.cockroachdb.com/cockroach-${version}.src.tgz";
+    url = "https://binaries.cockroachdb.com/cockroach-v${version}.src.tgz";
     sha256 = "0d2nlm291k4x7hqi0kh76j6pj8b1dwbdww5f95brf0a9bl1n7qxr";
   };
 
   nativeBuildInputs = [ cmake xz which autoconf ];
 
-  buildPhase =
+  buildPhase = ''
-    ''
+    runHook preBuild
-      cd $NIX_BUILD_TOP/go/src/${goPackagePath}
+    cd $NIX_BUILD_TOP/go/src/${goPackagePath}
-      patchShebangs ./
+    patchShebangs .
-      make buildoss
+    make buildoss
-      cd src/${goPackagePath}
+    cd src/${goPackagePath}
-      for asset in man autocomplete; do
+    for asset in man autocomplete; do
-        ./cockroach gen $asset
+      ./cockroach gen $asset
-      done
+    done
-    '';
+    runHook postBuild
+  '';
 
-  installPhase =
+  installPhase = ''
-    ''
+    runHook preInstall
-      mkdir -p $bin/{bin,share}
+    install -D cockroach $bin/bin/cockroach
-      mv cockroach $bin/bin/
+    install -D cockroach.bash $bin/share/bash-completion/completions/cockroach.bash
-      mv man $bin/share/
+    cp -r man $bin/share/man
-
+    runHook postInstall
-      mkdir -p $out/share/bash-completion/completions
+  '';
-      mv cockroach.bash $out/share/bash-completion/completions
-    '';
 
   meta = with stdenv.lib; {
     homepage = https://www.cockroachlabs.com;