From 43f02f27a0a4add09d5ceb468f1f618a43c35dcf Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Val=C3=A9rian=20Galliat?= Date: Sun, 22 Feb 2015 12:41:33 +0100 Subject: [PATCH] Shared libuv in io.js and Node.js --- pkgs/development/web/iojs/default.nix | 6 +++--- pkgs/development/web/nodejs/default.nix | 5 ++--- pkgs/top-level/all-packages.nix | 8 ++++---- 3 files changed, 9 insertions(+), 10 deletions(-) diff --git a/pkgs/development/web/iojs/default.nix b/pkgs/development/web/iojs/default.nix index 3129b10f7b8..deb6c535d4b 100644 --- a/pkgs/development/web/iojs/default.nix +++ b/pkgs/development/web/iojs/default.nix @@ -1,4 +1,4 @@ -{ stdenv, fetchurl, python, utillinux, openssl, http-parser, zlib, nightly ? false }: +{ stdenv, fetchurl, python, utillinux, openssl, http-parser, zlib, libuv, nightly ? false }: let version = if nightly then "1.2.1-nightly20150213f0296933f8" else "1.2.0"; @@ -19,9 +19,9 @@ in stdenv.mkDerivation { sed -e 's|^#!/usr/bin/env python$|#!${python}/bin/python|g' -i configure ''; - configureFlags = [ "--shared-openssl" "--shared-http-parser" "--shared-zlib" ]; + configureFlags = [ "--shared-openssl" "--shared-http-parser" "--shared-zlib" "--shared-libuv" ]; - buildInputs = [ python openssl http-parser zlib ] ++ (optional stdenv.isLinux utillinux); + buildInputs = [ python openssl http-parser zlib libuv ] ++ (optional stdenv.isLinux utillinux); setupHook = ../nodejs/setup-hook.sh; meta = { diff --git a/pkgs/development/web/nodejs/default.nix b/pkgs/development/web/nodejs/default.nix index 27bb65ccbc7..51abc90c277 100644 --- a/pkgs/development/web/nodejs/default.nix +++ b/pkgs/development/web/nodejs/default.nix @@ -1,4 +1,4 @@ -{ stdenv, fetchurl, openssl, python, zlib, v8, utillinux, http-parser +{ stdenv, fetchurl, openssl, python, zlib, libuv, v8, utillinux, http-parser , pkgconfig, runCommand, which, unstableVersion ? false }: @@ -10,9 +10,8 @@ let version = if unstableVersion then "0.11.13" else "0.12.0"; - # !!! Should we also do shared libuv? deps = { - inherit openssl zlib; + inherit openssl zlib libuv; # disabled system v8 because v8 3.14 no longer receives security fixes # we fall back to nodejs' internal v8 copy which receives backports for now diff --git a/pkgs/top-level/all-packages.nix b/pkgs/top-level/all-packages.nix index 85625d53860..105385a7f37 100644 --- a/pkgs/top-level/all-packages.nix +++ b/pkgs/top-level/all-packages.nix @@ -1724,15 +1724,15 @@ let ninka = callPackage ../development/tools/misc/ninka { }; - nodejs = callPackage ../development/web/nodejs { }; - nodejs-unstable = callPackage ../development/web/nodejs { unstableVersion = true; }; + nodejs = callPackage ../development/web/nodejs { libuv = libuvVersions.v1_2_0; }; + nodejs-unstable = callPackage ../development/web/nodejs { libuv = libuvVersions.v1_2_0; unstableVersion = true; }; nodePackages = recurseIntoAttrs ( callPackage ./node-packages.nix { self = nodePackages; } ); - iojs = callPackage ../development/web/iojs { }; - iojs-nightly = callPackage ../development/web/iojs { nightly = true; }; + iojs = callPackage ../development/web/iojs { libuv = libuvVersions.v1_4_0; }; + iojs-nightly = callPackage ../development/web/iojs { libuv = libuvVersions.v1_4_0; nightly = true; }; iojsPackages = recurseIntoAttrs ( callPackage ./node-packages.nix { self = iojsPackages; nodejs = iojs; }