kde5: fix all the Qt version dependencies

pkgs/desktops/kde-5/applications/ark/default.nix

@@ -1,7 +1,7 @@
 {
   kdeApp, lib,
 
-  extra-cmake-modules, kdoctools, makeQtWrapper,
+  ecm, kdoctools, makeQtWrapper,
 
   karchive, kconfig, kcrash, kdbusaddons, ki18n, kiconthemes, khtml, kio,
   kservice, kpty, kwidgetsaddons, libarchive,
@@ -13,7 +13,7 @@
 kdeApp {
   name = "ark";
   nativeBuildInputs = [
-    extra-cmake-modules kdoctools makeQtWrapper
+    ecm kdoctools makeQtWrapper
   ];
   propagatedBuildInputs = [
     khtml ki18n kio karchive kconfig kcrash kdbusaddons kiconthemes kservice

pkgs/desktops/kde-5/applications/baloo-widgets.nix

@@ -1,14 +1,7 @@
-{ kdeApp
+{
-, lib
+  kdeApp, lib,
-, extra-cmake-modules
+  ecm, kdoctools,
-, kdoctools
+  baloo, kconfig, kdelibs4support, kfilemetadata, ki18n, kio, kservice
-, kconfig
-, kio
-, ki18n
-, kservice
-, kfilemetadata
-, baloo
-, kdelibs4support
 }:
 
 kdeApp {
@@ -17,11 +10,8 @@ kdeApp {
     license = [ lib.licenses.lgpl21 ];
     maintainers = [ lib.maintainers.ttuegel ];
   };
-  nativeBuildInputs = [
+  nativeBuildInputs = [ ecm kdoctools ];
-    extra-cmake-modules
-    kdoctools
-  ];
   propagatedBuildInputs = [
-    baloo kconfig kservice kdelibs4support kfilemetadata ki18n kio
+    baloo kconfig kdelibs4support kfilemetadata ki18n kio kservice
   ];
 }

pkgs/desktops/kde-5/applications/default.nix

@@ -23,6 +23,7 @@ let
     kdeApp = import ./kde-app.nix {
       inherit kdeDerivation lib;
       inherit debug srcs;
+      inherit (pkgs) cmake pkgconfig;
     };
 
     kdelibs = callPackage ./kdelibs {
@@ -54,9 +55,7 @@ let
     libkexiv2 = callPackage ./libkexiv2.nix {};
     libkipi = callPackage ./libkipi.nix {};
     libkomparediff2 = callPackage ./libkomparediff2.nix {};
-    okular = callPackage ./okular.nix {
+    okular = callPackage ./okular.nix {};
-      inherit (srcs.okular) src version;
-    };
     print-manager = callPackage ./print-manager.nix {};
     spectacle = callPackage ./spectacle.nix {};
 

pkgs/desktops/kde-5/applications/dolphin-plugins.nix

@@ -1,12 +1,7 @@
-{ kdeApp
+{
-, lib
+  kdeApp, lib,
-, extra-cmake-modules
+  ecm, kdoctools,
-, kdoctools
+  dolphin, kdelibs4support, ki18n, kio, kxmlgui
-, kxmlgui
-, ki18n
-, kio
-, kdelibs4support
-, dolphin
 }:
 
 kdeApp {
@@ -15,11 +10,6 @@ kdeApp {
     license = [ lib.licenses.gpl2 ];
     maintainers = [ lib.maintainers.ttuegel ];
   };
-  nativeBuildInputs = [
+  nativeBuildInputs = [ ecm kdoctools ];
-    extra-cmake-modules
+  propagatedBuildInputs = [ dolphin kdelibs4support ki18n kio kxmlgui ];
-    kdoctools
-  ];
-  propagatedBuildInputs = [
-    kdelibs4support ki18n kio kxmlgui dolphin
-  ];
 }

pkgs/desktops/kde-5/applications/dolphin.nix

@@ -1,30 +1,10 @@
-{ kdeApp
+{
-, lib
+  kdeApp, lib,
-, extra-cmake-modules
+  ecm, kdoctools, makeQtWrapper,
-, kdoctools
+  baloo, baloo-widgets, kactivities, kbookmarks, kcmutils, kcompletion, kconfig,
-, makeQtWrapper
+  kcoreaddons, kdelibs4support, kdbusaddons, kfilemetadata, ki18n, kiconthemes,
-, kinit
+  kinit, kio, knewstuff, knotifications, kparts, ktexteditor, kwindowsystem,
-, kcmutils
+  phonon, solid
-, kcoreaddons
-, knewstuff
-, ki18n
-, kdbusaddons
-, kbookmarks
-, kconfig
-, kio
-, kparts
-, solid
-, kiconthemes
-, kcompletion
-, ktexteditor
-, kwindowsystem
-, knotifications
-, kactivities
-, phonon
-, baloo
-, baloo-widgets
-, kfilemetadata
-, kdelibs4support
 }:
 
 kdeApp {
@@ -33,16 +13,12 @@ kdeApp {
     license = with lib.licenses; [ gpl2 fdl12 ];
     maintainers = [ lib.maintainers.ttuegel ];
   };
-  nativeBuildInputs = [
+  nativeBuildInputs = [ ecm kdoctools makeQtWrapper ];
-    extra-cmake-modules
-    kdoctools
-    makeQtWrapper
-  ];
   propagatedBuildInputs = [
-    kinit kcmutils kcoreaddons knewstuff kdbusaddons kbookmarks kconfig kparts
+    baloo baloo-widgets kactivities kbookmarks kcmutils kcompletion kconfig
-    solid kiconthemes kcompletion knotifications phonon baloo-widgets baloo
+    kcoreaddons kdelibs4support kdbusaddons kfilemetadata ki18n kiconthemes
-    kactivities kdelibs4support kfilemetadata ki18n kio ktexteditor
+    kinit kio knewstuff knotifications kparts ktexteditor kwindowsystem phonon
-    kwindowsystem
+    solid
   ];
   postInstall = ''
     wrapQtProgram "$out/bin/dolphin"

pkgs/desktops/kde-5/applications/ffmpegthumbs.nix

@@ -1,8 +1,7 @@
-{ kdeApp
+{
-, lib
+  kdeApp, lib,
-, extra-cmake-modules
+  ecm,
-, ffmpeg
+  ffmpeg, kio
-, kio
 }:
 
 kdeApp {
@@ -11,11 +10,6 @@ kdeApp {
     license = with lib.licenses; [ gpl2 bsd3 ];
     maintainers = [ lib.maintainers.ttuegel ];
   };
-  nativeBuildInputs = [
+  nativeBuildInputs = [ ecm ];
-    extra-cmake-modules
+  propagatedBuildInputs = [ ffmpeg kio ];
-  ];
-  propagatedBuildInputs = [
-    ffmpeg
-    kio
-  ];
 }

pkgs/desktops/kde-5/applications/filelight.nix

@@ -1,13 +1,7 @@
-{ kdeApp
+{
-, lib
+  kdeApp, lib,
-, extra-cmake-modules
+  ecm, kdoctools, makeQtWrapper,
-, kdoctools
+  kio, kparts, kxmlgui, qtscript, solid
-, makeQtWrapper
-, qtscript
-, kio
-, solid
-, kxmlgui
-, kparts
 }:
 
 kdeApp {
@@ -16,13 +10,9 @@ kdeApp {
     license = with lib.licenses; [ gpl2 ];
     maintainers = with lib.maintainers; [ fridh vcunat ];
   };
-  nativeBuildInputs = [
+  nativeBuildInputs = [ ecm kdoctools makeQtWrapper ];
-    extra-cmake-modules
-    kdoctools
-    makeQtWrapper
-  ];
   propagatedBuildInputs = [
-    kio kparts qtscript solid kxmlgui
+    kio kparts kxmlgui qtscript solid
   ];
   postInstall = ''
     wrapQtProgram "$out/bin/filelight"

pkgs/desktops/kde-5/applications/gpgmepp.nix

@@ -1,8 +1,7 @@
-{ kdeApp
+{
-, lib
+  kdeApp, lib,
-, extra-cmake-modules
+  ecm,
-, boost
+  boost, gpgme
-, gpgme
 }:
 
 kdeApp {
@@ -11,10 +10,6 @@ kdeApp {
     license = with lib.licenses; [ lgpl21 bsd3 ];
     maintainers = [ lib.maintainers.ttuegel ];
   };
-  nativeBuildInputs = [
+  nativeBuildInputs = [ ecm ];
-    extra-cmake-modules
+  propagatedBuildInputs = [ boost gpgme ];
-  ];
-  propagatedBuildInputs = [
-    boost gpgme
-  ];
 }

pkgs/desktops/kde-5/applications/gwenview.nix

@@ -1,17 +1,8 @@
-{ kdeApp
+{
-, lib
+  kdeApp, lib,
-, extra-cmake-modules
+  ecm, kdoctools, makeQtWrapper,
-, kdoctools
+  baloo, exiv2, kactivities, kdelibs4support, kio, lcms2, phonon,
-, makeQtWrapper
+  qtsvg, qtx11extras
-, baloo
-, exiv2
-, kactivities
-, kdelibs4support
-, kio
-, lcms2
-, phonon
-, qtsvg
-, qtx11extras
 }:
 
 kdeApp {
@@ -20,11 +11,7 @@ kdeApp {
     license = with lib.licenses; [ gpl2 fdl12 ];
     maintainers = [ lib.maintainers.ttuegel ];
   };
-  nativeBuildInputs = [
+  nativeBuildInputs = [ ecm kdoctools makeQtWrapper ];
-    extra-cmake-modules
-    kdoctools
-    makeQtWrapper
-  ];
   propagatedBuildInputs = [
     baloo kactivities kdelibs4support kio qtx11extras exiv2 lcms2 phonon qtsvg
   ];

pkgs/desktops/kde-5/applications/kate.nix

@@ -1,9 +1,9 @@
 {
-  kdeApp, lib, makeQtWrapper, extra-cmake-modules, kdoctools,
+  kdeApp, lib, makeQtWrapper, ecm, kdoctools,
   kactivities, kconfig, kcrash, kguiaddons, kiconthemes, ki18n, kinit,
   kjobwidgets, kio, kparts, ktexteditor, kwindowsystem, kxmlgui, kdbusaddons,
-  kwallet, plasma-framework, kitemmodels, knotifications, qtscript, threadweaver,
+  kwallet, plasma-framework, kitemmodels, knotifications, qtscript,
-  knewstuff, libgit2
+  threadweaver, knewstuff, libgit2
 }:
 
 kdeApp {
@@ -12,9 +12,7 @@ kdeApp {
     license = with lib.licenses; [ gpl3 lgpl3 lgpl2 ];
     maintainers = [ lib.maintainers.ttuegel ];
   };
-  nativeBuildInputs = [
+  nativeBuildInputs = [ ecm kdoctools makeQtWrapper ];
-    extra-cmake-modules kdoctools makeQtWrapper
-  ];
   propagatedBuildInputs = [
     kactivities ki18n kio ktexteditor kwindowsystem plasma-framework qtscript
     kconfig kcrash kguiaddons kiconthemes kinit kjobwidgets kparts kxmlgui

pkgs/desktops/kde-5/applications/kcalc.nix

@@ -1,6 +1,6 @@
 {
   kdeApp, lib, makeQtWrapper, kdoctools,
-  extra-cmake-modules, kconfig, kconfigwidgets, kguiaddons, kinit,
+  ecm, kconfig, kconfigwidgets, kguiaddons, kinit,
   knotifications, gmp
 }:
 
@@ -10,7 +10,7 @@ kdeApp {
     license = with lib.licenses; [ gpl2 ];
     maintainers = [ lib.maintainers.fridh ];
   };
-  nativeBuildInputs = [ extra-cmake-modules kdoctools makeQtWrapper ];
+  nativeBuildInputs = [ ecm kdoctools makeQtWrapper ];
   propagatedBuildInputs = [
     gmp kconfig kconfigwidgets kguiaddons kinit knotifications
   ];

pkgs/desktops/kde-5/applications/kcolorchooser.nix

@@ -1,6 +1,6 @@
-{ kdeApp, lib
+{
-, extra-cmake-modules
+  kdeApp, lib,
-, ki18n, kwidgetsaddons, kxmlgui
+  ecm, ki18n, kwidgetsaddons, kxmlgui
 }:
 
 kdeApp {
@@ -9,6 +9,6 @@ kdeApp {
     license = with lib.licenses; [ mit ];
     maintainers = [ lib.maintainers.ttuegel ];
   };
-  nativeBuildInputs = [ extra-cmake-modules ];
+  nativeBuildInputs = [ ecm ];
   propagatedBuildInputs = [ ki18n kwidgetsaddons kxmlgui ];
 }

pkgs/desktops/kde-5/applications/kde-app.nix

@@ -1,4 +1,4 @@
-{ kdeDerivation, lib, debug, srcs }:
+{ kdeDerivation, lib, debug, srcs, cmake, pkgconfig }:
 
 args:
 
@@ -11,6 +11,15 @@ kdeDerivation (args // {
   name = "${name}-${version}";
   inherit src;
 
+  cmakeFlags =
+    (args.cmakeFlags or [])
+    ++ [ "-DBUILD_TESTING=OFF" ]
+    ++ lib.optional debug "-DCMAKE_BUILD_TYPE=Debug";
+
+  nativeBuildInputs =
+    (args.nativeBuildInputs or [])
+    ++ [ cmake pkgconfig ];
+
   meta = {
     platforms = lib.platforms.linux;
     homepage = "http://www.kde.org";

pkgs/desktops/kde-5/applications/kde-locale-5.nix

@@ -1,6 +1,6 @@
 name: args:
 
-{ kdeApp, cmake, extra-cmake-modules, gettext, kdoctools }:
+{ kdeApp, cmake, ecm, gettext, kdoctools }:
 
 kdeApp (args // {
   sname = "kde-l10n-${name}";
@@ -9,7 +9,7 @@ kdeApp (args // {
   outputs = [ "out" ];
 
   nativeBuildInputs =
-    [ cmake extra-cmake-modules gettext kdoctools ]
+    [ cmake ecm gettext kdoctools ]
     ++ (args.nativeBuildInputs or []);
 
   preConfigure = ''

pkgs/desktops/kde-5/applications/kdegraphics-thumbnailers.nix

@@ -1,9 +1,6 @@
-{ kdeApp
+{
-, lib
+  kdeApp, lib,
-, extra-cmake-modules
+  ecm, kio, libkexiv2, libkdcraw
-, kio
-, libkexiv2
-, libkdcraw
 }:
 
 kdeApp {
@@ -12,10 +9,6 @@ kdeApp {
     license = [ lib.licenses.lgpl21 ];
     maintainers = [ lib.maintainers.ttuegel ];
   };
-  nativeBuildInputs = [
+  nativeBuildInputs = [ ecm ];
-    extra-cmake-modules
+  propagatedBuildInputs = [ kio libkexiv2 libkdcraw ];
-  ];
-  propagatedBuildInputs = [
-    kio libkexiv2 libkdcraw
-  ];
 }

pkgs/desktops/kde-5/applications/kdelibs/default.nix

@@ -1,14 +1,13 @@
 {
-  stdenv, lib, src, version,
+  kdeApp, lib, src, version,
   automoc4, bison, cmake, flex, libxslt, perl, pkgconfig, shared_mime_info,
   attica, attr, avahi, docbook_xml_dtd_42, docbook_xsl, giflib, ilmbase,
   libdbusmenu_qt, libjpeg, libxml2, phonon, polkit_qt4, qca2, qt4,
   shared_desktop_ontologies, soprano, strigi, udev, xz, pcre
 }:
 
-stdenv.mkDerivation {
+kdeApp {
-  name = "kdelibs-${version}";
+  name = "kdelibs";
-  inherit src;
 
   outputs = [ "out" ];
 

pkgs/desktops/kde-5/applications/kdenetwork-filesharing.nix

@@ -1,12 +1,7 @@
-{ kdeApp
+{
-, lib
+  kdeApp, lib,
-, extra-cmake-modules
+  ecm, kdoctools,
-, kdoctools
+  kcoreaddons, ki18n, kio, kwidgetsaddons, samba
-, kcoreaddons
-, ki18n
-, kio
-, kwidgetsaddons
-, samba
 }:
 
 kdeApp {
@@ -15,11 +10,6 @@ kdeApp {
     license = [ lib.licenses.gpl2 lib.licenses.lgpl21 ];
     maintainers = [ lib.maintainers.ttuegel ];
   };
-  nativeBuildInputs = [
+  nativeBuildInputs = [ ecm kdoctools ];
-    extra-cmake-modules
+  propagatedBuildInputs = [ kcoreaddons ki18n kio kwidgetsaddons samba ];
-    kdoctools
-  ];
-  propagatedBuildInputs = [
-    kcoreaddons ki18n kio kwidgetsaddons samba
-  ];
 }

pkgs/desktops/kde-5/applications/kgpg.nix

@@ -1,32 +1,13 @@
-{ kdeApp
+{
-, lib
+  kdeApp, lib,
-, automoc4
+  automoc4, cmake, makeWrapper, perl, pkgconfig,
-, cmake
+  boost, gpgme, kdelibs, kdepimlibs, gnupg
-, makeWrapper
-, perl
-, pkgconfig
-, boost
-, gpgme
-, kdelibs
-, kdepimlibs
-, gnupg
 }:
 
 kdeApp {
   name = "kgpg";
-  nativeBuildInputs = [
+  nativeBuildInputs = [ automoc4 cmake makeWrapper perl pkgconfig ];
-    automoc4
+  buildInputs = [ boost gpgme kdelibs kdepimlibs ];
-    cmake
-    makeWrapper
-    perl
-    pkgconfig
-  ];
-  buildInputs = [
-    boost
-    gpgme
-    kdelibs
-    kdepimlibs
-  ];
   postInstall = ''
     wrapProgram "$out/bin/kgpg" \
         --prefix PATH : "${gnupg}/bin"

pkgs/desktops/kde-5/applications/khelpcenter.nix

@@ -1,18 +1,15 @@
-{ kdeApp, extra-cmake-modules, kdoctools, makeQtWrapper
+{
-, grantlee, kconfig, kcoreaddons, kdbusaddons, ki18n, kinit, kcmutils
+  kdeApp, ecm, kdoctools, makeQtWrapper,
-, kdelibs4support, khtml, kservice
+  grantlee, kconfig, kcoreaddons, kdbusaddons, ki18n, kinit, kcmutils,
-, xapian
+  kdelibs4support, khtml, kservice, xapian
 }:
 
 kdeApp {
   name = "khelpcenter";
-  nativeBuildInputs = [
+  nativeBuildInputs = [ ecm kdoctools makeQtWrapper ];
-    extra-cmake-modules kdoctools makeQtWrapper
-  ];
   buildInputs = [
     grantlee kdelibs4support khtml ki18n kconfig kcoreaddons kdbusaddons kinit
-    kcmutils kservice
+    kcmutils kservice xapian
-    xapian
   ];
   postInstall = ''
     wrapQtProgram "$out/bin/khelpcenter"

pkgs/desktops/kde-5/applications/kio-extras.nix

@@ -1,26 +1,9 @@
-{ kdeApp, lib
+{
-, extra-cmake-modules, kdoctools
+  kdeApp, lib, ecm, kdoctools, shared_mime_info,
-, shared_mime_info
+  exiv2, kactivities, karchive, kbookmarks, kconfig, kconfigwidgets,
-, exiv2
+  kcoreaddons, kdbusaddons, kguiaddons, kdnssd, kiconthemes, ki18n, kio, khtml,
-, kactivities, karchive
+  kdelibs4support, kpty, libmtp, libssh, openexr, ilmbase, openslp, phonon,
-, kbookmarks
+  qtsvg, samba, solid
-, kconfig, kconfigwidgets
-, kcoreaddons, kdbusaddons, kguiaddons
-, kdnssd
-, kiconthemes
-, ki18n
-, kio
-, khtml
-, kdelibs4support
-, kpty
-, libmtp
-, libssh
-, openexr, ilmbase
-, openslp
-, phonon
-, qtsvg
-, samba
-, solid
 }:
 
 kdeApp {
@@ -29,10 +12,7 @@ kdeApp {
     license = with lib.licenses; [ gpl2 lgpl21 ];
     maintainers = [ lib.maintainers.ttuegel ];
   };
-  nativeBuildInputs = [
+  nativeBuildInputs = [ ecm kdoctools shared_mime_info ];
-    extra-cmake-modules kdoctools
-    shared_mime_info
-  ];
   propagatedBuildInputs = [
     exiv2 kactivities karchive kbookmarks kconfig kconfigwidgets kcoreaddons
     kdbusaddons kguiaddons kdnssd kiconthemes ki18n kio khtml kdelibs4support

pkgs/desktops/kde-5/applications/kompare.nix

@@ -1,12 +1,6 @@
-{ kdeApp
+{
-, lib
+  kdeApp, lib, ecm, kdoctools, makeQtWrapper,
-, extra-cmake-modules
+  kparts, ktexteditor, kwidgetsaddons, libkomparediff2
-, kdoctools
-, makeQtWrapper
-, kparts
-, ktexteditor
-, kwidgetsaddons
-, libkomparediff2
 }:
 
 kdeApp {
@@ -15,18 +9,9 @@ kdeApp {
     license = with lib.licenses; [ gpl2 ];
   };
 
-  nativeBuildInputs = [
+  nativeBuildInputs = [ ecm kdoctools makeQtWrapper ];
-    extra-cmake-modules
-    kdoctools
-    makeQtWrapper
-  ];
 
-  propagatedBuildInputs = [
+  propagatedBuildInputs = [ kparts ktexteditor kwidgetsaddons libkomparediff2 ];
-    kparts
-    ktexteditor
-    kwidgetsaddons
-    libkomparediff2
-  ];
 
   postInstall = ''
     wrapQtProgram "$out/bin/kompare"

pkgs/desktops/kde-5/applications/konsole.nix

@@ -1,29 +1,10 @@
-{ kdeApp
+{
-, lib
+  kdeApp, lib,
-, extra-cmake-modules
+  ecm, kdoctools, makeQtWrapper,
-, kdoctools
+  kbookmarks, kcompletion, kconfig, kconfigwidgets, kcoreaddons, kguiaddons,
-, makeQtWrapper
+  ki18n, kiconthemes, kinit, kdelibs4support, kio, knotifications,
-, qtscript
+  knotifyconfig, kparts, kpty, kservice, ktextwidgets, kwidgetsaddons,
-, kbookmarks
+  kwindowsystem, kxmlgui, qtscript
-, kcompletion
-, kconfig
-, kconfigwidgets
-, kcoreaddons
-, kguiaddons
-, ki18n
-, kiconthemes
-, kinit
-, kdelibs4support
-, kio
-, knotifications
-, knotifyconfig
-, kparts
-, kpty
-, kservice
-, ktextwidgets
-, kwidgetsaddons
-, kwindowsystem
-, kxmlgui
 }:
 
 kdeApp {
@@ -32,9 +13,7 @@ kdeApp {
     license = with lib.licenses; [ gpl2 lgpl21 fdl12 ];
     maintainers = [ lib.maintainers.ttuegel ];
   };
-  nativeBuildInputs = [
+  nativeBuildInputs = [ ecm kdoctools makeQtWrapper ];
-    extra-cmake-modules kdoctools makeQtWrapper
-  ];
   propagatedBuildInputs = [
     kdelibs4support ki18n kwindowsystem qtscript kbookmarks kcompletion kconfig
     kconfigwidgets kcoreaddons kguiaddons kiconthemes kinit kio knotifications

pkgs/desktops/kde-5/applications/libkdcraw.nix

@@ -1,8 +1,4 @@
-{ kdeApp
+{ kdeApp, lib, ecm, libraw }:
-, lib
-, extra-cmake-modules
-, libraw
-}:
 
 kdeApp {
   name = "libkdcraw";
@@ -10,10 +6,6 @@ kdeApp {
     license = with lib.licenses; [ gpl2 lgpl21 bsd3 ];
     maintainers = [ lib.maintainers.ttuegel ];
   };
-  nativeBuildInputs = [
+  nativeBuildInputs = [ ecm ];
-    extra-cmake-modules
+  propagatedBuildInputs = [ libraw ];
-  ];
-  propagatedBuildInputs = [
-    libraw
-  ];
 }

pkgs/desktops/kde-5/applications/libkexiv2.nix

@@ -1,8 +1,4 @@
-{ kdeApp
+{ kdeApp, lib, exiv2, ecm }:
-, lib
-, exiv2
-, extra-cmake-modules
-}:
 
 kdeApp {
   name = "libkexiv2";
@@ -10,10 +6,6 @@ kdeApp {
     license = with lib.licenses; [ gpl2 lgpl21 bsd3 ];
     maintainers = [ lib.maintainers.ttuegel ];
   };
-  nativeBuildInputs = [
+  nativeBuildInputs = [ ecm ];
-    extra-cmake-modules
+  propagatedBuildInputs = [ exiv2 ];
-  ];
-  propagatedBuildInputs = [
-    exiv2
-  ];
 }

pkgs/desktops/kde-5/applications/libkipi.nix

@@ -1,11 +1,4 @@
-{ kdeApp
+{ kdeApp, lib, ecm, kconfig, ki18n, kservice, kxmlgui }:
-, lib
-, extra-cmake-modules
-, kconfig
-, ki18n
-, kservice
-, kxmlgui
-}:
 
 kdeApp {
   name = "libkipi";
@@ -13,10 +6,6 @@ kdeApp {
     license = with lib.licenses; [ gpl2 lgpl21 bsd3 ];
     maintainers = [ lib.maintainers.ttuegel ];
   };
-  nativeBuildInputs = [
+  nativeBuildInputs = [ ecm ];
-    extra-cmake-modules
+  propagatedBuildInputs = [ kconfig ki18n kservice kxmlgui ];
-  ];
-  propagatedBuildInputs = [
-    kconfig ki18n kservice kxmlgui
-  ];
 }

pkgs/desktops/kde-5/applications/libkomparediff2.nix

@@ -1,23 +1,7 @@
-{ kdeApp
+{ kdeApp, lib, ecm, ki18n, kxmlgui, kcodecs, kio }:
-, lib
-, extra-cmake-modules
-, ki18n
-, kxmlgui
-, kcodecs
-, kio
-}:
 
 kdeApp {
   name = "libkomparediff2";
-
+  nativeBuildInputs = [ ecm ];
-  nativeBuildInputs = [
+  propagatedBuildInputs = [ kcodecs ki18n kxmlgui kio ];
-    extra-cmake-modules
-  ];
-
-  propagatedBuildInputs = [
-    kcodecs
-    ki18n
-    kxmlgui
-    kio
-  ];
 }

pkgs/desktops/kde-5/applications/okular.nix

@@ -1,14 +1,12 @@
 {
   stdenv, lib,
-  src, version,
   automoc4, cmake, perl, pkgconfig, kdelibs, qimageblitz,
   poppler_qt4, libspectre, libkexiv2, djvulibre, libtiff, freetype,
   ebook_tools
 }:
 
 stdenv.mkDerivation {
-  name = "okular-${version}";
+  name = "okular";
-  inherit src;
   nativeBuildInputs = [ automoc4 cmake perl pkgconfig ];
   buildInputs = [
     kdelibs qimageblitz poppler_qt4 libspectre libkexiv2 djvulibre libtiff

pkgs/desktops/kde-5/applications/print-manager.nix

@@ -1,20 +1,8 @@
-{ kdeApp
+{
-, lib
+  kdeApp, lib, ecm,
-, extra-cmake-modules
+  cups, kconfig, kconfigwidgets, kdbusaddons, kiconthemes, ki18n, kcmutils, kio,
-, qtdeclarative
+  knotifications, kwidgetsaddons, kwindowsystem, kitemviews, plasma-framework,
-, cups
+  qtdeclarative
-, kconfig
-, kconfigwidgets
-, kdbusaddons
-, kiconthemes
-, ki18n
-, kcmutils
-, kio
-, knotifications
-, plasma-framework
-, kwidgetsaddons
-, kwindowsystem
-, kitemviews
 }:
 
 kdeApp {
@@ -23,9 +11,7 @@ kdeApp {
     license = [ lib.licenses.gpl2 ];
     maintainers = [ lib.maintainers.ttuegel ];
   };
-  nativeBuildInputs = [
+  nativeBuildInputs = [ ecm ];
-    extra-cmake-modules
-  ];
   propagatedBuildInputs = [
     cups kconfig kconfigwidgets kdbusaddons kiconthemes kcmutils knotifications
     kwidgetsaddons kitemviews ki18n kio kwindowsystem plasma-framework

pkgs/desktops/kde-5/applications/spectacle.nix

@@ -1,20 +1,7 @@
-{ kdeApp, lib
+{
-, extra-cmake-modules
+  kdeApp, lib, ecm, kdoctools, makeQtWrapper,
-, kdoctools
+  kconfig, kcoreaddons, kdbusaddons, kdeclarative, ki18n, kio, knotifications,
-, makeQtWrapper
+  kscreen, kwidgetsaddons, kwindowsystem, kxmlgui, libkipi, xcb-util-cursor
-, kconfig
-, kcoreaddons
-, kdbusaddons
-, kdeclarative
-, ki18n
-, kio
-, knotifications
-, kscreen
-, kwidgetsaddons
-, kwindowsystem
-, kxmlgui
-, libkipi
-, xcb-util-cursor
 }:
 
 kdeApp {
@@ -22,9 +9,7 @@ kdeApp {
   meta = with lib; {
     maintainers = with maintainers; [ ttuegel ];
   };
-  nativeBuildInputs = [
+  nativeBuildInputs = [ ecm kdoctools makeQtWrapper ];
-    extra-cmake-modules kdoctools makeQtWrapper
-  ];
   propagatedBuildInputs = [
     kconfig kcoreaddons kdbusaddons kdeclarative ki18n kio knotifications
     kscreen kwidgetsaddons kwindowsystem kxmlgui libkipi xcb-util-cursor

pkgs/development/libraries/kde-frameworks/default.nix

@@ -22,10 +22,6 @@ let
 
     kdeDerivation = args:
       let
-        setupHook =
-          let drv = { qtbase, qttools }:
-                makeSetupHook { deps = [ qtbase qttools ]; } ./setup-hook.sh;
-          in callPackage drv {};
       in stdenv.mkDerivation (args // {
 
         outputs = args.outputs or [ "dev" "out" ];
@@ -37,7 +33,7 @@ let
 
         nativeBuildInputs =
           (args.nativeBuildInputs or [])
-          ++ [ pkgs.cmake pkgs.pkgconfig setupHook ];
+          ++ [ pkgs.cmake pkgs.pkgconfig ecm ];
 
       });
 
@@ -62,6 +58,12 @@ let
     baloo = callPackage ./baloo.nix {};
     bluez-qt = callPackage ./bluez-qt.nix {};
     breeze-icons = callPackage ./breeze-icons.nix {};
+    ecm =
+      let drv = { qtbase, qttools }:
+            makeSetupHook
+            { deps = [ extra-cmake-modules qtbase qttools ]; }
+            ./setup-hook.sh;
+      in callPackage drv {};
     extra-cmake-modules = callPackage ./extra-cmake-modules {
       inherit (srcs.extra-cmake-modules) src version;
     };