From 61fad2cdceb6dc6181d3208fc5acced2515f36e0 Mon Sep 17 00:00:00 2001 From: Robert Scott Date: Tue, 18 Dec 2018 17:53:01 +0000 Subject: [PATCH 1/3] cloudfoundry-cli: fix build on multiple platforms, notably darwin, to produce correct binary for target --- .../development/tools/cloudfoundry-cli/default.nix | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/pkgs/development/tools/cloudfoundry-cli/default.nix b/pkgs/development/tools/cloudfoundry-cli/default.nix index 3ce9e64c0f7..bdcc8b18d21 100644 --- a/pkgs/development/tools/cloudfoundry-cli/default.nix +++ b/pkgs/development/tools/cloudfoundry-cli/default.nix @@ -17,9 +17,20 @@ buildGoPackage rec { outputs = [ "out" ]; + makeTarget = let hps = stdenv.hostPlatform.system; in + if hps == "x86_64-darwin" then + "out/cf-cli_osx" + else if hps == "x86_64-linux" then + "out/cf-cli_linux_x86-64" + else if hps == "i686-linux" then + "out/cf-cli_linux_i686" + else + throw "make target for this platform unknown"; + buildPhase = '' cd go/src/${goPackagePath} - CF_BUILD_DATE="1970-01-01" make build + CF_BUILD_DATE="1970-01-01" make $makeTarget + cp $makeTarget out/cf ''; installPhase = '' @@ -33,5 +44,6 @@ buildGoPackage rec { homepage = https://github.com/cloudfoundry/cli; maintainers = with maintainers; [ ris ]; license = licenses.asl20; + platforms = [ "i686-linux" "x86_64-linux" "x86_64-darwin" ]; }; } From 8e5c4a4c1d10fad4fa8e0dc96fae7516fdc8ba29 Mon Sep 17 00:00:00 2001 From: Robert Scott Date: Thu, 20 Dec 2018 22:49:13 +0000 Subject: [PATCH 2/3] cloudfoundry-cli: output to "bin" output, don't "remove-references-to" --- pkgs/development/tools/cloudfoundry-cli/default.nix | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/pkgs/development/tools/cloudfoundry-cli/default.nix b/pkgs/development/tools/cloudfoundry-cli/default.nix index bdcc8b18d21..283b17378e3 100644 --- a/pkgs/development/tools/cloudfoundry-cli/default.nix +++ b/pkgs/development/tools/cloudfoundry-cli/default.nix @@ -15,8 +15,6 @@ buildGoPackage rec { sha256 = "1v4f1fyydpzkfir46g4ppbf3zmk3ym6kxswpkdjls8h3dbb2fbnv"; }; - outputs = [ "out" ]; - makeTarget = let hps = stdenv.hostPlatform.system; in if hps == "x86_64-darwin" then "out/cf-cli_osx" @@ -34,9 +32,8 @@ buildGoPackage rec { ''; installPhase = '' - install -Dm555 out/cf "$out/bin/cf" - remove-references-to -t ${go} "$out/bin/cf" - install -Dm444 -t "$out/share/bash-completion/completions/" "$src/ci/installers/completion/cf" + install -Dm555 out/cf "$bin/bin/cf" + install -Dm444 -t "$bin/share/bash-completion/completions/" "$src/ci/installers/completion/cf" ''; meta = with stdenv.lib; { From 9046038d6cded077ed3553f0c008a9939b78bcb4 Mon Sep 17 00:00:00 2001 From: Robert Scott Date: Wed, 19 Dec 2018 12:50:42 +0000 Subject: [PATCH 3/3] cloudfoundry-cli: 6.37.0 -> 6.41.0 --- pkgs/development/tools/cloudfoundry-cli/default.nix | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkgs/development/tools/cloudfoundry-cli/default.nix b/pkgs/development/tools/cloudfoundry-cli/default.nix index 283b17378e3..4f285fa6961 100644 --- a/pkgs/development/tools/cloudfoundry-cli/default.nix +++ b/pkgs/development/tools/cloudfoundry-cli/default.nix @@ -2,7 +2,7 @@ buildGoPackage rec { name = "cloudfoundry-cli-${version}"; - version = "6.37.0"; + version = "6.41.0"; goPackagePath = "code.cloudfoundry.org/cli"; @@ -12,7 +12,7 @@ buildGoPackage rec { owner = "cloudfoundry"; repo = "cli"; rev = "v${version}"; - sha256 = "1v4f1fyydpzkfir46g4ppbf3zmk3ym6kxswpkdjls8h3dbb2fbnv"; + sha256 = "1dkd0lfq55qpnxsrigffaqm2nlcxr0bm0jsl4rsjlmb8p2vgpx8b"; }; makeTarget = let hps = stdenv.hostPlatform.system; in