From d35009ee63af7a43ae3ebe6367cd01c40012b83f Mon Sep 17 00:00:00 2001
From: Dmitry Kalinkin <dmitry.kalinkin@gmail.com>
Date: Mon, 24 Feb 2020 03:30:16 -0500
Subject: [PATCH] python3Packages.ipykernel: fix build on darwin
Also python34 is not supported:
https://github.com/ipython/ipykernel/commit/979e6fd2db9824934a89d97011d3f3eccc6d4499
nixpkgs doesn't provide python34 anymore, so pythonOlder "3.5" is always
true and can be removed.
---
.../python-modules/ipykernel/default.nix | 16 +++++++++++++---
1 file changed, 13 insertions(+), 3 deletions(-)
diff --git a/pkgs/development/python-modules/ipykernel/default.nix b/pkgs/development/python-modules/ipykernel/default.nix
index 6e356665d04..9c0ab175004 100644
--- a/pkgs/development/python-modules/ipykernel/default.nix
+++ b/pkgs/development/python-modules/ipykernel/default.nix
@@ -16,7 +16,6 @@
buildPythonPackage rec {
pname = "ipykernel";
version = "5.1.4";
- disabled = pythonOlder "3.4";
src = fetchPypi {
inherit pname version;
@@ -38,12 +37,23 @@ buildPythonPackage rec {
preCheck = ''
export HOME=$(mktemp -d)
'';
- disabledTests = lib.optionals stdenv.isDarwin [
+ disabledTests = lib.optionals stdenv.isDarwin ([
# see https://github.com/NixOS/nixpkgs/issues/76197
"test_subprocess_print"
"test_subprocess_error"
"test_ipython_start_kernel_no_userns"
- ];
+ ] ++ lib.optionals (pythonOlder "3.8") [
+ # flaky test https://github.com/ipython/ipykernel/issues/485
+ "test_shutdown"
+
+ # test regression https://github.com/ipython/ipykernel/issues/486
+ "test_sys_path_profile_dir"
+ "test_save_history"
+ "test_help_output"
+ "test_write_kernel_spec"
+ "test_ipython_start_kernel_userns"
+ "ZMQDisplayPublisherTests"
+ ]);
# Some of the tests use localhost networking.
__darwinAllowLocalNetworking = true;