From 3369b350317f0be0b9b75846a84ef69463dfcdaa Mon Sep 17 00:00:00 2001 From: Dhruv Dang Date: Sun, 23 Aug 2020 22:21:24 -0700 Subject: [PATCH] #84563 #95931 fix ghcjs 8.6 so it builds --- .../development/compilers/ghcjs-ng/8.6/dep-overrides.nix | 9 ++++++--- pkgs/development/compilers/ghcjs-ng/default.nix | 3 +-- .../haskell-modules/configuration-ghc-8.6.x.nix | 8 ++++++++ 3 files changed, 15 insertions(+), 5 deletions(-) diff --git a/pkgs/development/compilers/ghcjs-ng/8.6/dep-overrides.nix b/pkgs/development/compilers/ghcjs-ng/8.6/dep-overrides.nix index c54c782fafa..c2f2cb3b81a 100644 --- a/pkgs/development/compilers/ghcjs-ng/8.6/dep-overrides.nix +++ b/pkgs/development/compilers/ghcjs-ng/8.6/dep-overrides.nix @@ -1,11 +1,14 @@ -{ haskellLib }: +{ lib, haskellLib, fetchFromGitHub }: -let inherit (haskellLib) doJailbreak dontHaddock; +let inherit (haskellLib) doJailbreak dontHaddock dontCheck; in self: super: { + ghcjs = super.ghcjs.override { + shelly = super.shelly_1_8_1; + }; ghc-api-ghcjs = super.ghc-api-ghcjs.override { happy = self.happy_1_19_5; }; - haddock-library-ghcjs = doJailbreak super.haddock-library-ghcjs; + haddock-library-ghcjs = doJailbreak (dontCheck super.haddock-library-ghcjs); haddock-api-ghcjs = doJailbreak (dontHaddock super.haddock-api-ghcjs); } diff --git a/pkgs/development/compilers/ghcjs-ng/default.nix b/pkgs/development/compilers/ghcjs-ng/default.nix index 6d56c410aab..7b6fbc460a9 100644 --- a/pkgs/development/compilers/ghcjs-ng/default.nix +++ b/pkgs/development/compilers/ghcjs-ng/default.nix @@ -102,7 +102,6 @@ in stdenv.mkDerivation { inherit passthru; - meta.broken = true; # build does not succeed - meta.platforms = lib.platforms.none; # passthru.bootPkgs.ghc.meta.platforms; + meta.platforms = passthru.bootPkgs.ghc.meta.platforms; meta.maintainers = [lib.maintainers.elvishjerricco]; } diff --git a/pkgs/development/haskell-modules/configuration-ghc-8.6.x.nix b/pkgs/development/haskell-modules/configuration-ghc-8.6.x.nix index 339fda5d6fb..f68eec94200 100644 --- a/pkgs/development/haskell-modules/configuration-ghc-8.6.x.nix +++ b/pkgs/development/haskell-modules/configuration-ghc-8.6.x.nix @@ -94,4 +94,12 @@ self: super: { # Only 0.6 is compatible with ghc 8.6 https://hackage.haskell.org/package/apply-refact/changelog apply-refact = super.apply-refact_0_6_0_0; + + # ghcjs 8.6.x relies on shelly < 1.9.0 (default is 1.9.0 in current package set, adding 1.8.1). + shelly_1_8_1 = super.callCabal2nix "shelly" (pkgs.fetchFromGitHub { + owner = "gregwebs"; + repo = "Shelly.hs"; + rev = "d0a185c7dee96820fc3652e7603d81a28276d76c"; + sha256 = "173msjlq6yxpvd3900ajmd8znyg9kfg5csbxbiz4m7hvxkg8kbkn"; + }) {}; }