public
/
nixpkgs
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

update contributors documentation for nix-review (#73217) 

Useful for newcomers who want to do their review after committing and then stumbling across the PR checklist.

* replace nix-shell with nix run
This commit is contained in:
DavHau 2019-11-13 03:41:30 +07:00 committed by markuskowa
parent b252047216
commit 331f45f7bb
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
doc/contributing/submitting-changes.xml
View File

@ -298,14 +298,17 @@ Additional information.
<para> <para>
review changes from pull request number 12345: review changes from pull request number 12345:
<screen>nix-shell -p nix-review --run "nix-review pr 12345"</screen> <screen>nix run nixpkgs.nix-review -c nix-review pr 12345</screen>
</para> </para>
<para> <para>
review uncommitted changes: review uncommitted changes:
<screen>nix-shell -p nix-review --run "nix-review wip"</screen> <screen>nix run nixpkgs.nix-review -c nix-review wip</screen>
</para> </para>
</section>
<para>
review changes from last commit:
<screen>nix run nixpkgs.nix-review -c nix-review rev HEAD</screen>
<section xml:id="submitting-changes-tested-execution"> <section xml:id="submitting-changes-tested-execution">
<title>Tested execution of all binary files (usually in <filename>./result/bin/</filename>)</title> <title>Tested execution of all binary files (usually in <filename>./result/bin/</filename>)</title>