From 046390bf97cd52b28b96b476688ff97e1cf9e5c4 Mon Sep 17 00:00:00 2001 From: Roman Volosatovs Date: Mon, 29 Jul 2019 10:44:34 +0200 Subject: [PATCH 1/3] kitty: 0.14.2 -> 0.14.3 --- pkgs/applications/misc/kitty/default.nix | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/pkgs/applications/misc/kitty/default.nix b/pkgs/applications/misc/kitty/default.nix index 0be9bc82187..a3841989123 100644 --- a/pkgs/applications/misc/kitty/default.nix +++ b/pkgs/applications/misc/kitty/default.nix @@ -9,6 +9,7 @@ IOKit, Kernel, OpenGL, + libcanberra, libicns, libpng, librsvg, @@ -20,18 +21,20 @@ with python3Packages; buildPythonApplication rec { pname = "kitty"; - version = "0.14.2"; + version = "0.14.3"; format = "other"; src = fetchFromGitHub { owner = "kovidgoyal"; repo = "kitty"; rev = "v${version}"; - sha256 = "15iv3k7iryf10n8n67d37x24pzcarq97a3dr42lbld00k1lx19az"; + sha256 = "0wi6b6b1nyp16rcpcghk6by62wy6qsamv1xdymyn0zbqgd8h9n6b"; }; buildInputs = [ - ncurses harfbuzz + harfbuzz + libcanberra + ncurses ] ++ stdenv.lib.optionals stdenv.isDarwin [ Cocoa CoreGraphics From 4536e3fbf4caba9d13403bda37bc022eff09e34d Mon Sep 17 00:00:00 2001 From: Dmitry Kalinkin Date: Mon, 29 Jul 2019 11:15:13 -0400 Subject: [PATCH 2/3] kitty: fix patch for darwin --- pkgs/applications/misc/kitty/png2icns.patch | 40 +++++++++++---------- 1 file changed, 21 insertions(+), 19 deletions(-) diff --git a/pkgs/applications/misc/kitty/png2icns.patch b/pkgs/applications/misc/kitty/png2icns.patch index d2d0806c862..68566e2a899 100644 --- a/pkgs/applications/misc/kitty/png2icns.patch +++ b/pkgs/applications/misc/kitty/png2icns.patch @@ -1,19 +1,21 @@ ---- a/setup.py -+++ b/setup.py -@@ -744,9 +744,15 @@ Categories=System;TerminalEmulator; - if not os.path.exists(logo_dir): - raise SystemExit('The kitty logo has not been generated, you need to run logo/make.py') - subprocess.check_call([ -- 'iconutil', '-c', 'icns', logo_dir, '-o', -+ 'png2icns', - os.path.join('Resources', os.path.basename(logo_dir).partition('.')[0] + '.icns') -- ]) -+ ] + [os.path.join(logo_dir, logo) for logo in ( -+ 'icon_128x128.png', -+ 'icon_16x16.png', -+ 'icon_256x256.png', -+ 'icon_32x32.png', -+ 'icon_512x512.png', -+ )]) - # }}} - # }}} +diff -aru a/setup.py b/setup.py +--- a/setup.py 2019-07-29 11:09:32.000000000 -0400 ++++ b/setup.py 2019-07-29 11:11:37.000000000 -0400 +@@ -784,9 +784,15 @@ + def create_macos_app_icon(where='Resources'): + logo_dir = os.path.abspath(os.path.join('logo', appname + '.iconset')) + subprocess.check_call([ +- 'iconutil', '-c', 'icns', logo_dir, '-o', ++ 'png2icns', + os.path.join(where, os.path.basename(logo_dir).partition('.')[0] + '.icns') +- ]) ++ ] + [os.path.join(logo_dir, logo) for logo in [ ++ 'icon_128x128.png', ++ 'icon_16x16.png', ++ 'icon_256x256.png', ++ 'icon_32x32.png', ++ 'icon_512x512.png', ++ ]]) + + + def create_minimal_macos_bundle(args, where): From 0283abb4e84261ad9e4f6ce16933246b6d7f246d Mon Sep 17 00:00:00 2001 From: Dmitry Kalinkin Date: Mon, 29 Jul 2019 11:26:16 -0400 Subject: [PATCH 3/3] kitty: libcanberra is not needed on darwin --- pkgs/applications/misc/kitty/default.nix | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/pkgs/applications/misc/kitty/default.nix b/pkgs/applications/misc/kitty/default.nix index a3841989123..01f33cd5b12 100644 --- a/pkgs/applications/misc/kitty/default.nix +++ b/pkgs/applications/misc/kitty/default.nix @@ -33,7 +33,6 @@ buildPythonApplication rec { buildInputs = [ harfbuzz - libcanberra ncurses ] ++ stdenv.lib.optionals stdenv.isDarwin [ Cocoa @@ -46,7 +45,7 @@ buildPythonApplication rec { python3 zlib ] ++ stdenv.lib.optionals stdenv.isLinux [ - fontconfig glfw libunistring libX11 + fontconfig glfw libunistring libcanberra libX11 libXrandr libXinerama libXcursor libxkbcommon libXi libXext wayland-protocols wayland dbus ];