From 2a135eb4d41e6046578e4520a52a92991b733e7c Mon Sep 17 00:00:00 2001
From: Eelco Dolstra <eelco.dolstra@logicblox.com>
Date: Thu, 22 Mar 2012 12:24:23 +0000
Subject: [PATCH] =?UTF-8?q?*=20Remove=20the=20=E2=80=98services.nfs.client?=
 =?UTF-8?q?.enable=E2=80=99=20flag;=20use=20=20=20=E2=80=98boot.supportedF?=
 =?UTF-8?q?ilesystems=20=3D=20[=20"nfs"=20]=E2=80=99=20if=20needed.?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

svn path=/nixos/trunk/; revision=33356
---
 modules/services/network-filesystems/nfsd.nix |  2 +-
 modules/tasks/filesystems.nix                 |  6 -----
 modules/tasks/filesystems/nfs.nix             | 23 +++++++------------
 3 files changed, 9 insertions(+), 22 deletions(-)

diff --git a/modules/services/network-filesystems/nfsd.nix b/modules/services/network-filesystems/nfsd.nix
index dba2db22621..b4dc014d68e 100644
--- a/modules/services/network-filesystems/nfsd.nix
+++ b/modules/services/network-filesystems/nfsd.nix
@@ -69,7 +69,7 @@ in
 
     services.rpcbind.enable = true;
 
-    services.nfs.client.enable = true; # needed for statd and idmapd
+    boot.supportedFilesystems = [ "nfs" ]; # needed for statd and idmapd
 
     environment.systemPackages = [ pkgs.nfsUtils ];
 
diff --git a/modules/tasks/filesystems.nix b/modules/tasks/filesystems.nix
index 57a020a4a25..739d63bf479 100644
--- a/modules/tasks/filesystems.nix
+++ b/modules/tasks/filesystems.nix
@@ -184,12 +184,6 @@ in
           ''
             # Ensure that this job is restarted when fstab changed:
             # ${fstab}
-            
-            ${optionalString config.services.nfs.client.enable ''
-              ensure statd || true
-              ensure idmapd || true
-            ''}
-
             echo "mounting filesystems..."
           '';
 
diff --git a/modules/tasks/filesystems/nfs.nix b/modules/tasks/filesystems/nfs.nix
index e54cb814f50..740a3b6e447 100644
--- a/modules/tasks/filesystems/nfs.nix
+++ b/modules/tasks/filesystems/nfs.nix
@@ -31,23 +31,9 @@ in
 
 {
 
-  ###### interface
-
-  options = {
-
-    services.nfs.client.enable = mkOption {
-      default = any (fs: fs.fsType == "nfs" || fs.fsType == "nfs4") config.fileSystems;
-      description = ''
-        Whether to enable support for mounting NFS filesystems.
-      '';
-    };
-
-  };
-
-
   ###### implementation
 
-  config = mkIf config.services.nfs.client.enable {
+  config = mkIf (any (fs: fs == "nfs" || fs == "nfs4") config.boot.supportedFilesystems) {
 
     services.rpcbind.enable = true;
     
@@ -63,6 +49,13 @@ in
 
     environment.etc = singleton idmapdConfFile;
 
+    # Ensure that statd and idmapd are started before mountall.
+    jobs.mountall.preStart =
+      ''
+        ensure statd || true
+        ensure idmapd || true
+      '';
+
     jobs.statd =
       { description = "Kernel NFS server - Network Status Monitor";