From 280f4c12e2e45745e039c42c712df5deb5022123 Mon Sep 17 00:00:00 2001 From: sternenseemann <0rpkxez4ksa01gb3typccl0i@systemli.org> Date: Thu, 1 Apr 2021 23:21:50 +0200 Subject: [PATCH] haskellPackages.lsp-test: temporarily remove override This override currently breaks eval, but is probably still necessary in some form. However the change to fix it is non-trivial and not quickly actionable as hls-plugins-api currently is broken so the intended target of the override (haskell-language-server) can't be tested. Something in a similar spirit would be pinning lsp-test to 0.14.0.0 which would however require to pick this patch from haskell-language-server master: https://github.com/haskell/haskell-language-server/commit/6d1f1a55e39a9fd905bea13d6144125fcb42a594 To me this sounds like a promising solution as it also adjusts to lsp 1.2 which we now have in haskellPackages. Supposedly it also fixes some tests, so maybe we can remove the dontCheck. cc @maralorn --- pkgs/development/haskell-modules/configuration-common.nix | 3 --- 1 file changed, 3 deletions(-) diff --git a/pkgs/development/haskell-modules/configuration-common.nix b/pkgs/development/haskell-modules/configuration-common.nix index bbfd606cc87..23e3aa96eb0 100644 --- a/pkgs/development/haskell-modules/configuration-common.nix +++ b/pkgs/development/haskell-modules/configuration-common.nix @@ -1413,9 +1413,6 @@ self: super: { # 2021-03-19: https://github.com/Avi-D-coder/implicit-hie-cradle/pull/8 implicit-hie-cradle = doJailbreak super.implicit-hie-cradle; - # 2021-03-09: Overrides because nightly is to old for hls 1.0.0 - lsp-test = doDistribute (dontCheck self.lsp-test_0_13_0_0); - # 2021-03-09: Golden tests seem to be missing in hackage release: # https://github.com/haskell/haskell-language-server/issues/1536 hls-tactics-plugin = dontCheck super.hls-tactics-plugin;