From 1e211a70cbdaf230a18ea4cb67a959039d5c2ddb Mon Sep 17 00:00:00 2001 From: Maximilian Bosch Date: Fri, 28 Sep 2018 23:42:55 +0200 Subject: [PATCH] nixos/zsh: use `escapeShelLArg' for shell aliases (#47471) Previously single quotes were used by default for aliases and the module never warned about possible collisions when having a shell alias which relies on single quotes. Adding `escapeShellArg` works around this fixes the issue and ensures that a properly quoted value is written to `/etc/zshrc`. --- nixos/modules/programs/zsh/zsh.nix | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/nixos/modules/programs/zsh/zsh.nix b/nixos/modules/programs/zsh/zsh.nix index b4ca8730958..865d148c162 100644 --- a/nixos/modules/programs/zsh/zsh.nix +++ b/nixos/modules/programs/zsh/zsh.nix @@ -11,7 +11,7 @@ let cfg = config.programs.zsh; zshAliases = concatStringsSep "\n" ( - mapAttrsFlatten (k: v: "alias ${k}='${v}'") cfg.shellAliases + mapAttrsFlatten (k: v: "alias ${k}=${escapeShellArg v}") cfg.shellAliases ); in