From 11e2f31532e754256b1a6fa021364a7329d8635c Mon Sep 17 00:00:00 2001 From: Matthew Bauer Date: Sat, 24 Nov 2018 13:46:54 -0600 Subject: [PATCH] kmymoney: cleanup install check A few things changed: - no need for stdenv.hostPlatform == stdenv.buildPlatform conditional - this is already done in make-derivation - put xvfb_run in installCheckInputs --- pkgs/applications/office/kmymoney/default.nix | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/pkgs/applications/office/kmymoney/default.nix b/pkgs/applications/office/kmymoney/default.nix index 7899bf607e5..19bf8a8a740 100644 --- a/pkgs/applications/office/kmymoney/default.nix +++ b/pkgs/applications/office/kmymoney/default.nix @@ -60,12 +60,11 @@ stdenv.mkDerivation rec { "$out/share/kmymoney/weboob/kmymoneyweboob.py" ''; - doInstallCheck = stdenv.hostPlatform == stdenv.buildPlatform; - installCheckPhase = let - pluginPath = "${qtbase.bin}/${qtbase.qtPluginPrefix}"; - in lib.optionalString doInstallCheck '' - QT_PLUGIN_PATH=${lib.escapeShellArg pluginPath} CTEST_OUTPUT_ON_FAILURE=1 \ - ${xvfb_run}/bin/xvfb-run -s '-screen 0 1024x768x24' make test \ + doInstallCheck = true; + installCheckInputs = [ xvfb_run ]; + installCheckPhase = '' + QT_PLUGIN_PATH=${lib.escapeShellArg "${qtbase.bin}/${qtbase.qtPluginPrefix}"} \ + xvfb-run -s '-screen 0 1024x768x24' make test \ ARGS="-E '(reports-chart-test)'" # Test fails, so exclude it for now. '';