From 433df32ddb83a90f95c7b37c6fd6b68d46cb9100 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Domen=20Ko=C5=BEar?= Date: Wed, 28 Apr 2021 19:58:29 +0200 Subject: [PATCH 1/2] editorconfig check: instruct user what to do --- .github/workflows/editorconfig.yml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.github/workflows/editorconfig.yml b/.github/workflows/editorconfig.yml index 2d7b9d7ce84..a6e9eb8718b 100644 --- a/.github/workflows/editorconfig.yml +++ b/.github/workflows/editorconfig.yml @@ -39,3 +39,7 @@ jobs: if: env.PR_DIFF run: | echo "$PR_DIFF" | xargs editorconfig-checker -disable-indent-size + - if: ${{ failure() }} + run: | + echo "::error :: Hey! It looks like your changes don't follow our editorconfig settings. Read https://editorconfig.org/#download to configure your editor so you never see this error again." + From 77215825ded540a994c5299b016d2e2c010c3940 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Domen=20Ko=C5=BEar?= Date: Wed, 28 Apr 2021 20:07:05 +0200 Subject: [PATCH 2/2] editorconfig check: avoid channels as they might break one day --- .github/workflows/editorconfig.yml | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/.github/workflows/editorconfig.yml b/.github/workflows/editorconfig.yml index a6e9eb8718b..4960e9fd3d2 100644 --- a/.github/workflows/editorconfig.yml +++ b/.github/workflows/editorconfig.yml @@ -3,6 +3,7 @@ name: "Checking EditorConfig" permissions: read-all on: + # avoids approving first time contributors pull_request_target: branches-ignore: - 'release-**' @@ -29,11 +30,11 @@ jobs: if: env.PR_DIFF - uses: cachix/install-nix-action@v13 if: env.PR_DIFF - - name: install editorconfig-checker from unstable channel - run: | - nix-channel --add https://nixos.org/channels/nixpkgs-unstable - nix-channel --update - nix-env -iA nixpkgs.editorconfig-checker + with: + # nixpkgs commit is pinned so that it doesn't break + nix_path: nixpkgs=https://github.com/NixOS/nixpkgs/archive/f93ecc4f6bc60414d8b73dbdf615ceb6a2c604df.tar.gz + - name: install editorconfig-checker + run: nix-env -iA editorconfig-checker -f '' if: env.PR_DIFF - name: Checking EditorConfig if: env.PR_DIFF