From 652e8584096d762ab9519ab651977db21c3d1726 Mon Sep 17 00:00:00 2001 From: Jan Tojnar Date: Tue, 30 Jul 2019 18:16:32 +0200 Subject: [PATCH 1/5] libuchardet: remove unneeded CMake flags Not necessary since https://github.com/NixOS/nixpkgs/pull/52856 --- pkgs/development/libraries/libuchardet/default.nix | 3 --- 1 file changed, 3 deletions(-) diff --git a/pkgs/development/libraries/libuchardet/default.nix b/pkgs/development/libraries/libuchardet/default.nix index 5aa26a749e4..6bfb694a41b 100644 --- a/pkgs/development/libraries/libuchardet/default.nix +++ b/pkgs/development/libraries/libuchardet/default.nix @@ -15,9 +15,6 @@ stdenv.mkDerivation rec { cmakeFlags = [ "-DCMAKE_SKIP_BUILD_RPATH=OFF" # for tests - # TODO: move the following to CMake setup hook - "-DCMAKE_INSTALL_BINDIR=${placeholder "bin"}/bin" - "-DCMAKE_INSTALL_MANDIR=${placeholder "man"}/share/man" ]; doCheck = true; From 0568b622d58c0473b6190e4b33954a2f42919072 Mon Sep 17 00:00:00 2001 From: Jan Tojnar Date: Tue, 30 Jul 2019 20:18:20 +0200 Subject: [PATCH 2/5] libjpeg_turbo: remove unneeded CMake flags Not necessary since https://github.com/NixOS/nixpkgs/pull/52856 --- pkgs/development/libraries/libjpeg-turbo/default.nix | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/pkgs/development/libraries/libjpeg-turbo/default.nix b/pkgs/development/libraries/libjpeg-turbo/default.nix index 371d7b838d4..191c375f3be 100644 --- a/pkgs/development/libraries/libjpeg-turbo/default.nix +++ b/pkgs/development/libraries/libjpeg-turbo/default.nix @@ -18,7 +18,9 @@ stdenv.mkDerivation rec { nativeBuildInputs = [ cmake nasm ]; - cmakeFlags = [ "-DCMAKE_INSTALL_BINDIR=${placeholder "bin"}/bin" "-DENABLE_STATIC=0" ]; + cmakeFlags = [ + "-DENABLE_STATIC=0" + ]; doInstallCheck = true; installCheckTarget = "test"; From 2e11dca0ad8689fa80361cd32adb52b16c875637 Mon Sep 17 00:00:00 2001 From: Jan Tojnar Date: Tue, 30 Jul 2019 20:25:30 +0200 Subject: [PATCH 3/5] openimageio2: remove unneeded CMake flags Not necessary since https://github.com/NixOS/nixpkgs/pull/52856 --- pkgs/applications/graphics/openimageio/2.x.nix | 2 -- 1 file changed, 2 deletions(-) diff --git a/pkgs/applications/graphics/openimageio/2.x.nix b/pkgs/applications/graphics/openimageio/2.x.nix index 837446190fb..8644341ec21 100644 --- a/pkgs/applications/graphics/openimageio/2.x.nix +++ b/pkgs/applications/graphics/openimageio/2.x.nix @@ -45,8 +45,6 @@ stdenv.mkDerivation rec { "-DUSE_PYTHON=OFF" "-DUSE_QT=OFF" # GNUInstallDirs - "-DCMAKE_INSTALL_BINDIR=${placeholder "bin"}/bin" - "-DCMAKE_INSTALL_INCLUDEDIR=${placeholder "dev"}/include" "-DCMAKE_INSTALL_LIBDIR=lib" # needs relative path for pkgconfig ]; From 6928f1e8386df386f8a3452595fef82123bd51a3 Mon Sep 17 00:00:00 2001 From: Jan Tojnar Date: Tue, 30 Jul 2019 20:26:36 +0200 Subject: [PATCH 4/5] openimageio: remove unneeded CMake flags Not necessary since https://github.com/NixOS/nixpkgs/pull/52856 --- pkgs/applications/graphics/openimageio/default.nix | 2 -- 1 file changed, 2 deletions(-) diff --git a/pkgs/applications/graphics/openimageio/default.nix b/pkgs/applications/graphics/openimageio/default.nix index 00b33b65216..7225efadebd 100644 --- a/pkgs/applications/graphics/openimageio/default.nix +++ b/pkgs/applications/graphics/openimageio/default.nix @@ -23,8 +23,6 @@ stdenv.mkDerivation rec { cmakeFlags = [ "-DUSE_PYTHON=OFF" - # GNUInstallDirs - "-DCMAKE_INSTALL_BINDIR=${placeholder "bin"}/bin" ]; makeFlags = [ From 9aa10f05fd0529dfeebfa097808aebe7f70882cd Mon Sep 17 00:00:00 2001 From: Jan Tojnar Date: Tue, 30 Jul 2019 20:29:15 +0200 Subject: [PATCH 5/5] shaderc: remove unneeded CMake flags Not necessary since https://github.com/NixOS/nixpkgs/pull/52856 Parallel building is enabled by default with CMake. --- pkgs/development/compilers/shaderc/default.nix | 4 ---- 1 file changed, 4 deletions(-) diff --git a/pkgs/development/compilers/shaderc/default.nix b/pkgs/development/compilers/shaderc/default.nix index 7f4c895d85a..75717b5ba09 100644 --- a/pkgs/development/compilers/shaderc/default.nix +++ b/pkgs/development/compilers/shaderc/default.nix @@ -48,10 +48,6 @@ in stdenv.mkDerivation rec { moveToOutput "lib/*.a" $static ''; - preConfigure = ''cmakeFlags="$cmakeFlags -DCMAKE_INSTALL_BINDIR=$bin/bin"''; - - enableParallelBuilding = true; - cmakeFlags = [ "-DSHADERC_SKIP_TESTS=ON" ]; meta = with stdenv.lib; {