From 08463affc0b322b14286e183bf6534df826e6906 Mon Sep 17 00:00:00 2001 From: happysalada Date: Mon, 15 Feb 2021 11:24:15 +0900 Subject: [PATCH] nodePackages: fix generate.sh failure when gc is automatically enabled --- pkgs/development/node-packages/generate.sh | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/pkgs/development/node-packages/generate.sh b/pkgs/development/node-packages/generate.sh index 5f9936c5124..e7a15d5d869 100755 --- a/pkgs/development/node-packages/generate.sh +++ b/pkgs/development/node-packages/generate.sh @@ -2,8 +2,13 @@ set -eu -o pipefail DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null 2>&1 && pwd )" -node2nix=$(nix-build ../../.. --no-out-link -A nodePackages.node2nix) - +node2nix=$(nix-build ../../.. -A nodePackages.node2nix) cd ${DIR} rm -f ./node-env.nix ${node2nix}/bin/node2nix -i node-packages.json -o node-packages.nix -c composition.nix +# using --no-out-link in nix-build argument would cause the +# gc to run before the script finishes +# which would cause a failure +# it's safer to just remove the link after the script finishes +# see https://github.com/NixOS/nixpkgs/issues/112846 for more details +rm ./result