* grub-menu-builder.sh: with copyKernels = true, don't delete all of

/boot/kernels and then copy all the kernels/initrds.  Instead, copy
  only the kernels/initrds that don't exist yet in /boot/kernels, then
  delete obsolete files in /boot/kernels.  Also, use slightly nicer
  file names in /boot/kernels.

svn path=/nixos/trunk/; revision=15505

installer/grub-menu-builder.sh

@@ -15,6 +15,9 @@ bootMount="@bootMount@"
 if test -z "$bootMount"; then bootMount=/boot; fi
 
 
+echo "updating the Grub menu..."
+
+
 target=/boot/grub/menu.lst
 tmp=$target.tmp
 
@@ -27,14 +30,13 @@ GRUBEND
 
 if test -n "@grubSplashImage@"; then
     splashLocation=@grubSplashImage@
-    # !!! image in /nix/store doesn't seem to work
-    #if test -n "@copyKernels@"; then
+    # Splash images in /nix/store don't seem to work, so copy them.
     cp -f $splashLocation /boot/background.xpm.gz
     splashLocation="$bootMount/background.xpm.gz"
-    #fi
     echo "splashimage $splashLocation" >> $tmp
 fi
 
+
 configurationCounter=0
 configurationLimit="@configurationLimit@"
 numAlienEntries=`cat <<EOF | egrep '^[[:space:]]*title' | wc -l
@@ -45,15 +47,45 @@ if test $((configurationLimit+numAlienEntries)) -gt 190; then
     configurationLimit=$((190-numAlienEntries));
 fi
 
+
+# Convert a path to a file in the Nix store such as
+# /nix/store/<hash>-<name>/file to <hash>-<name>-<file>.
+cleanName() {
+    local path="$1"
+    echo "$path" | sed 's|^/nix/store/||' | sed 's|/|-|g'
+}
+
+
+# Copy a file from the Nix store to /boot/kernels.
+declare -A filesCopied
+
+copyToKernelsDir() {
+    local src="$1"
+    local dst="/boot/kernels/$(cleanName $src)"
+    # Don't copy the file if $dst already exists.  This means that we
+    # have to create $dst atomically to prevent partially copied
+    # kernels or initrd if this script is ever interrupted.
+    if ! test -e $dst; then
+        local dstTmp=$dst.tmp.$$
+        cp $src $dstTmp
+        mv $dstTmp $dst
+    fi
+    filesCopied[$dst]=1
+    result=$dst
+}
+
+
+# Add an entry for a configuration to the Grub menu, and if
+# appropriate, copy its kernel and initrd to /boot/kernels.
 addEntry() {
     local name="$1"
     local path="$2"
     local shortSuffix="$3"
 
     configurationCounter=$((configurationCounter + 1))
-    if test $configurationCounter -gt @configurationLimit@ ; then
+    if test $configurationCounter -gt @configurationLimit@; then
 	return
-    fi;
+    fi
 
     if ! test -e $path/kernel -a -e $path/initrd; then
         return
@@ -74,30 +106,21 @@ EOF
     fi
 
     if test -n "@copyKernels@"; then
-        local kernel2=/boot/kernels/$(echo $kernel | sed 's^/^-^g')
-        if ! test -e $kernel2; then
-            cp $kernel $kernel2
+        copyToKernelsDir $kernel; kernel=$result
+        copyToKernelsDir $initrd; initrd=$result
     fi
-        kernel=$kernel2
-
-        local initrd2=/boot/kernels/$(echo $initrd | sed 's^/^-^g')
-        if ! test -e $initrd2; then
-            cp $initrd $initrd2
-        fi
-        initrd=$initrd2
     
     if test -n "$bootMount"; then
-          kernel=$(echo $kernel2 | sed -e "s^/boot^$bootMount^")
-          initrd=$(echo $initrd2 | sed -e "s^/boot^$bootMount^")
-        fi
+        kernel=$(echo $kernel | sed -e "s^/boot^$bootMount^")
+        initrd=$(echo $initrd | sed -e "s^/boot^$bootMount^")
     fi
     
     local confName=$(if test -e $path/configuration-name; then 
 	cat $path/configuration-name; 
-    fi);
-    if test -n "$confName" ; then
-	name="$confName $3";
-    fi;
+    fi)
+    if test -n "$confName"; then
+	name="$confName $3"
+    fi
 
     cat >> $tmp << GRUBEND
 
@@ -108,11 +131,11 @@ GRUBEND
 }
 
 
-rm -rf /boot/kernels
 if test -n "@copyKernels@"; then
     mkdir -p /boot/kernels
 fi
 
+
 # Additional entries specified verbatim by the configuration.
 extraGrubEntries=`cat <<EOF
 @extraGrubEntries@
@@ -135,11 +158,11 @@ for link in $((ls -d $default/fine-tune/* ) | sort -n); do
     date=$(stat --printf="%y\n" $link | sed 's/\..*//')
     addEntry "NixOS - variation" $link ""
 done
+
 for generation in $(
     (cd /nix/var/nix/profiles && ls -d system-*-link) \
     | sed 's/system-\([0-9]\+\)-link/\1/' \
     | sort -n -r); do
-    echo $generation
     link=/nix/var/nix/profiles/system-$generation-link
     date=$(stat --printf="%y\n" $link | sed 's/\..*//')
     kernelVersion=$(cd $(dirname $(readlink -f $link/kernel))/lib/modules && echo *)
@@ -150,3 +173,11 @@ done
 # Atomically update /boot/grub/menu.lst.  !!! should do an fsync()
 # here on $tmp, especially on ext4.
 mv $tmp $target
+
+
+# Remove obsolete files from /boot/kernels.
+for fn in $(ls /boot/kernels/*); do
+    if ! test "${filesCopied[$fn]}" = 1; then
+        rm -vf -- "$fn"
+    fi
+done

system/options.nix

@@ -593,13 +593,6 @@ in
     ";
   };
 
-  servicesProposal = {
-    # see upstart-jobs/default.nix 
-    # the option declarations can be found in the upstart-jobs/newProposal/*.nix files
-    # one way to include the declarations here is adding kind of glob "*.nix"
-    # file function to builtins to get all jobs
-    # then the checking in upstart-jobs/default.nix can be removed again (together with passing arg optionDeclarations)
-  };
   
   services = {
 
@@ -652,6 +645,7 @@ in
           the `at' commands are setuid/setgid `atd'.
         '';
       };
+      
     };
 
 

system/switch-to-configuration.sh

@@ -50,8 +50,8 @@ EOF
     oldEvents=$(readlink -f /etc/event.d || true)
     newEvents=$(readlink -f @out@/etc/event.d)
 
-    echo "old: $oldEvents"
-    echo "new: $newEvents"
+    #echo "old: $oldEvents"
+    #echo "new: $newEvents"
 
     stopJob() {
         local job=$1
@@ -73,7 +73,7 @@ EOF
 
     # Activate the new configuration (i.e., update /etc, make
     # accounts, and so on).
-    echo "Activating the configuration..."
+    echo "activating the configuration..."
     @out@/activate @out@
 
     # Make Upstart reload its events.  !!! Should wait until it has