From 051389eb1875b088be07aa5e9a15c19e88f9ba07 Mon Sep 17 00:00:00 2001 From: Louis Bettens Date: Thu, 31 Dec 2020 17:42:30 +0100 Subject: [PATCH] brave: test rpath in installCheck This check helps with making sure that we provide all the required shared libraries to brave. If something is missing, the command will get ENOENT, otherwise it should terminate normally. --- pkgs/applications/networking/browsers/brave/default.nix | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/pkgs/applications/networking/browsers/brave/default.nix b/pkgs/applications/networking/browsers/brave/default.nix index 9931b6003fb..92177183b0c 100644 --- a/pkgs/applications/networking/browsers/brave/default.nix +++ b/pkgs/applications/networking/browsers/brave/default.nix @@ -98,6 +98,7 @@ stdenv.mkDerivation rec { dontConfigure = true; dontBuild = true; dontPatchELF = true; + doInstallCheck = true; nativeBuildInputs = [ dpkg wrapGAppsHook ]; @@ -147,6 +148,11 @@ stdenv.mkDerivation rec { ln -sf ${xdg_utils}/bin/xdg-mime $out/opt/brave.com/brave/xdg-mime ''; + installCheckPhase = '' + # Bypass upstream wrapper which suppresses errors + $out/opt/brave.com/brave/brave --version + ''; + passthru.updateScript = ./update.sh; meta = with stdenv.lib; {