public
/
nixpkgs
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

jemalloc: do not expose hugepage support as an option 

The only common use case so far seems ARMv6/ARMv7 support.
The way this option is exposed might collide with a package with the
same name. Also the option naming on its own is not self-descriptive
without context.
This commit is contained in:
Jörg Thalheim 2018-01-02 15:23:17 +01:00
parent 98dd418e85
commit 02e95ea0b5
1 changed files with 5 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
pkgs/development/libraries/jemalloc/default.nix
View File

@ -1,8 +1,4 @@
{ stdenv, fetchurl, { stdenv, fetchurl }:
# jemalloc is unable to correctly detect transparent hugepage support on
# ARM (https://github.com/jemalloc/jemalloc/issues/526), and the default
# kernel ARMv6/7 kernel does not enable it, so we explicitly disable support
thpSupport ? !stdenv.isArm }:
stdenv.mkDerivation rec { stdenv.mkDerivation rec {
name = "jemalloc-${version}"; name = "jemalloc-${version}";
@ -17,11 +13,12 @@ stdenv.mkDerivation rec {
# then stops downstream builds (mariadb in particular) from detecting it. This # then stops downstream builds (mariadb in particular) from detecting it. This
# option should remove the prefix and give us a working jemalloc. # option should remove the prefix and give us a working jemalloc.
configureFlags = stdenv.lib.optional stdenv.isDarwin "--with-jemalloc-prefix=" configureFlags = stdenv.lib.optional stdenv.isDarwin "--with-jemalloc-prefix="
++ stdenv.lib.optional (!thpSupport) "--disable-thp"; # jemalloc is unable to correctly detect transparent hugepage support on
# ARM (https://github.com/jemalloc/jemalloc/issues/526), and the default
# kernel ARMv6/7 kernel does not enable it, so we explicitly disable support
++ stdenv.lib.optional stdenv.isArm "--disable-thp";
doCheck = true; doCheck = true;
meta = with stdenv.lib; { meta = with stdenv.lib; {
homepage = http://jemalloc.net; homepage = http://jemalloc.net;
description = "General purpose malloc(3) implementation"; description = "General purpose malloc(3) implementation";