From 021c6f2d98835690c784fc4b23beb2947559fd3b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sandro=20J=C3=A4ckel?= <sandro.jaeckel@gmail.com> Date: Tue, 5 Jan 2021 16:57:05 +0100 Subject: [PATCH] pythonPackages.google_cloud_error_reporting: Cleanups --- .../google_cloud_error_reporting/default.nix | 29 +++++++++++++------ 1 file changed, 20 insertions(+), 9 deletions(-) diff --git a/pkgs/development/python-modules/google_cloud_error_reporting/default.nix b/pkgs/development/python-modules/google_cloud_error_reporting/default.nix index 19f90275ae9..196ec4a912b 100644 --- a/pkgs/development/python-modules/google_cloud_error_reporting/default.nix +++ b/pkgs/development/python-modules/google_cloud_error_reporting/default.nix @@ -1,6 +1,14 @@ -{ stdenv, buildPythonPackage, fetchPypi, pytestCheckHook, pythonOlder -, google_cloud_logging, google_cloud_testutils, libcst, mock, proto-plus -, pytest-asyncio }: +{ stdenv +, buildPythonPackage +, fetchPypi +, pytestCheckHook +, google_cloud_logging +, google_cloud_testutils +, libcst +, mock +, proto-plus +, pytest-asyncio +}: buildPythonPackage rec { pname = "google-cloud-error-reporting"; @@ -11,13 +19,16 @@ buildPythonPackage rec { sha256 = "2fd6fe25343f7017c22e2733a0358c64b3171edc1669d0c8a1e1f07f86a048c4"; }; - disabled = pythonOlder "3.6"; - - checkInputs = [ google_cloud_testutils mock pytestCheckHook pytest-asyncio ]; propagatedBuildInputs = [ google_cloud_logging libcst proto-plus ]; - # Disable tests that require credentials - disabledTests = [ "test_report_error_event" "test_report_exception" ]; + checkInputs = [ google_cloud_testutils mock pytestCheckHook pytest-asyncio ]; + + disabledTests = [ + # require credentials + "test_report_error_event" + "test_report_exception" + ]; + # prevent google directory from shadowing google imports preCheck = '' rm -r google @@ -27,6 +38,6 @@ buildPythonPackage rec { description = "Stackdriver Error Reporting API client library"; homepage = "https://github.com/googleapis/python-error-reporting"; license = licenses.asl20; - maintainers = [ maintainers.costrouc ]; + maintainers = with maintainers; [ SuperSandro2000 ]; }; }