public
/
nixpkgs
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
nixpkgs/.github/PULL_REQUEST_TEMPLATE.md

20 lines
648 B
Markdown
Raw Normal View History

Update PR template with motivation for changes I'm seeing a lot of PRs that only include the checklist, when the main thing I care about when I'm reviewing a PR is what the author was thinking when they decided to make the change.
2016-05-24 04:59:46 -07:00
###### Motivation for this change
Simplify contributing * Highlight the top mistakes directly in CONTRIBUTING.md * Remove unecessary cruft from the PR template
2016-04-09 09:53:24 -07:00
###### Things done
PULL_REQUEST_TEMPLATE: fix issues raised in 3c84ae406
2016-02-28 01:26:21 -08:00
github PR template: reformulate the sandboxing help It's been reported that when running through nix daemon, sandboxing can't be turned on by passing `--option` (silently ignored), so let's not suggest that way. https://github.com/NixOS/nixpkgs/issues/14866#issuecomment-214619909
2016-04-26 00:14:39 -07:00
- [ ] Tested using sandboxing
PULL_REQUEST_TEMPLATE: rename chroot to sandbox See https://github.com/NixOS/nix/commit/b39622a487e2978bd32c9faf2f651aec1f9815c1
2016-09-02 12:41:43 -07:00
([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS,
or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file)
github PR template: reformulate the sandboxing help It's been reported that when running through nix daemon, sandboxing can't be turned on by passing `--option` (silently ignored), so let's not suggest that way. https://github.com/NixOS/nixpkgs/issues/14866#issuecomment-214619909
2016-04-26 00:14:39 -07:00
on non-NixOS)
.github/PULL_REQUEST_TEMPLATE.md: use individual checkboxes for tested OSes
2016-03-16 01:46:05 -07:00
- Built on platform(s)
- [ ] NixOS
- [ ] OS X
- [ ] Linux
PULL_REQUEST_TEMPLATE.md: clarify a few things
2016-02-28 00:49:55 -08:00
- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
- [ ] Tested execution of all binary files (usually in `./result/bin/`)
PULL_REQUEST_TEMPLATE: init
2016-02-18 08:26:17 -08:00
- [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).
---